-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the rulers implementation. #263
Comments
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
pixelzoom
added a commit
that referenced
this issue
Dec 7, 2021
Lots of work on this today, including a chunk of PhET-iO instrumentation. The relevant classes are now:
TODO:
|
I'm going to revise transforms in #277. In summary, I used a modified version of the Creator pattern. It's really not creating anything, but is instead using 2 static instances of rulers. This works better for PhET-iO, where static instance are preferred. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A couple of problems with the current implementation of rulers:
(1) The rulers toolbox uses some elements of the Creator pattern, but it's not quite right. And it needs to be right in order to support (and possibly facilitate) alt input design for the toolbox, in #258.
(2) It creates a new RulerNode each time the scale changes (zoom in/out). This will be a problem for PhET-iO, where it is very-much preferred to have static elements (because dynamic elements are painful).
Relevant classes are:
The text was updated successfully, but these errors were encountered: