Add screen name to title when multiscreen sim is run with one screen via ?screens=3

[zepumph]

From #445:

when multiscreen sim and you specify 1 screen with ?screens=2, then update the title in the nav bar to include the screen name: "Forces and Motion: Basics — Motion"

This seems like a nice improvement across the board, and will be especially nice is PhET-iO. I will take a stab at this and then ask for review since it touches every multiscreen sim.

[zepumph]

Commit is above. @samreid will you please review.

[samreid]

I suspect we will need to internationalize this using a pattern so it will work well for RTL languages as well.

[zepumph]

How about that implementation? Especially the name of the string key, I feel like I'm bad at naming those things.

[samreid]

There is a lint error:

/Users/samreid/github/joist/js/NavigationBar.js
45:3 error Mismatched var in require(string!), key=simTitleWithScreenNamePattern, var=simTitleWithScreenNamePattern, desiredVar=simTitleWithScreenNamePatternString string-require-statement-match

[samreid]

Everything else looks good to me.

[samreid]

Do @kathy-phet and @ariel-phet want maintenance releases of this feature for our LOL sims?

[kathy-phet]

It's not a high priority, but if it can be done without much difficulty, it seems worthwhile. Not time sensitive either.

[zepumph]

@samreid I'm very un-involved in the LOL process, what sims would need this if we decide it is worth the cost?

[zepumph]

@samreid I see #450, want to just add these commits into that?

a3e46b8
d418f9e
28a9c13

[samreid]

@zepumph will prevent cases like "Concentration -- Concentration"

[samreid]

Or it should error out if you put ?screens=... for a one screen sim?

UPDATE: we decided it should be an error if someone specifies ?screens for a single screen sim.

[pixelzoom]

11/2/17 dev meeting:

Do this only in the navbar, not in the About dialog or Report A Problem. Also not in the browser title because that may mess up statistics.

[kathy-phet]

Sounds decided - only in the nav bar.

[samreid]

@zepumph anything else to do for this issue other than #449 (comment)
?

Also, please unhold #450 when complete.

[jonathanolson]

phetsims/pendulum-lab#197 also waiting for this (it looks like).

[zepumph]

Looks good, closing!

[jonathanolson]

Is there a list of commits to cherry-pick to apply this to a maintenance release branch?

[zepumph]

#449 (comment)

[jonathanolson]

Thanks!

[zepumph]

I'm pretty sure that we decided that we decided that we weren't going to update the title anywhere else but the nav bar title. This decision included the 'report a problem' report, but I wanted to make sure that this was alright with @phet-steele. @phet-steele please close if this sounds good to you.

[phet-steele]

@phet-steele please close if this sounds good to you.

Yup, just making sure we covered all of our bases.