Fold Options into Preferences.

[pixelzoom]

Related to #835, and summary of Zoom discussion with @jessegreenberg ...

• Any sim that has an Options dialog (uses SimOptions createOptionsDialogContent) will need to be folded into Preferences.
• This will probably involve using SimOptions preferencesConfiguration instead of createOptionsDialogContent.
• If the Options dialog uses ProjectorModeCheckbox, it should be removed, and instead added to the Preferences "Visual" tab.

These sims use createOptionsDialogContent but only have a ProjectorModeCheckbox:

• atomic-interactions
• blackbody-spectrum
• charges-and-fields
• coulombs-law
• diffusion
• models-of-the-hydrogen-atom
• rutherford-scattering
• states-of-matter
• states-of-matter-basics

These sims use createOptionsDialogContent and have controls that should appear in Preferences "Visual" tab:

• build-an-atom
• center-and-variability
• circuit-construction-kit-common
• gas-properties
• gases-intro
• geometric-optics
• molecule-polarity
• molecule-shapes
• molecule-shapes-basics
• tambo

[zepumph]

These sims use createOptionsDialogContent and have controls that should appear in Preferences "Visual" tab:

In that case, it will probably want to hold off until #835 has been worked out. If options are totally sim-specific, then we can proceed using PreferencesConfiguration.createSimControls

[zepumph]

Definitely on hold until we finish #835, there is a new API for creating custom preferences, even in the general tab.

[zepumph]

Now unblocked! Yay

[zepumph]

I converted the ProjectorMode-checkbox-only sims over to preferences above. It lost PhET-iO instrumentation on some, but consistency is good. If we want the checkbox instrumented in the future, we will add it then.

[pixelzoom]

On Slack, we discussed the {sim}.global.model.preferences convention mentioned above.

Instead of defining this everywhere, like I've done in my sims:

const preferencesTandem = Tandem.GLOBAL_MODEL.createTandem( 'preferences' );

In the above commits, I've added this to Tandem.ts:

/**
 * Use this as the parent tandem for Properties that are related to sim-specific preferences.
 */
Tandem.PREFERENCES = Tandem.GLOBAL_MODEL.createTandem( 'preferences' );

So we should use Tandem.PREFERENCES for preferences Properties. And if the designers decide they want preferences Properties somewhere else in the Studio tree, we can just change Tandem.PREFERENCES.

[jessegreenberg]

OK, the PhET-iO changes described in the previous three comments are done. I think everything discussed in this issue is now complete. @zepumph can you think of anything else to review or do here?

[zepumph]

All looks good here. Thanks @pixelzoom and @jessegreenberg!!! Ready to close?

[zepumph]

Please note that we will be adding a PhET-iO migration rule because we removed the OptionsDialog menu item (and whole dialog). See phetsims/gravity-and-orbits#434

[jessegreenberg]

Commits above look good. I believe so, closing.