-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fold Options into Preferences. #837
Comments
In that case, it will probably want to hold off until #835 has been worked out. If options are totally sim-specific, then we can proceed using |
Definitely on hold until we finish #835, there is a new API for creating custom preferences, even in the general tab. |
Now unblocked! Yay |
I converted the ProjectorMode-checkbox-only sims over to preferences above. It lost PhET-iO instrumentation on some, but consistency is good. If we want the checkbox instrumented in the future, we will add it then. |
On Slack, we discussed the Instead of defining this everywhere, like I've done in my sims:
In the above commits, I've added this to Tandem.ts:
So we should use |
OK, the PhET-iO changes described in the previous three comments are done. I think everything discussed in this issue is now complete. @zepumph can you think of anything else to review or do here? |
All looks good here. Thanks @pixelzoom and @jessegreenberg!!! Ready to close? |
Please note that we will be adding a PhET-iO migration rule because we removed the OptionsDialog menu item (and whole dialog). See phetsims/gravity-and-orbits#434 |
Commits above look good. I believe so, closing. |
Related to #835, and summary of Zoom discussion with @jessegreenberg ...
createOptionsDialogContent
) will need to be folded into Preferences.preferencesConfiguration
instead ofcreateOptionsDialogContent
.These sims use
createOptionsDialogContent
but only have a ProjectorModeCheckbox:These sims use
createOptionsDialogContent
and have controls that should appear in Preferences "Visual" tab:The text was updated successfully, but these errors were encountered: