Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamic locale #140

Closed
pixelzoom opened this issue Aug 30, 2022 · 10 comments
Closed

Add support for dynamic locale #140

pixelzoom opened this issue Aug 30, 2022 · 10 comments
Assignees
@arouinfar
Labels
dev:phet-io status:ready-for-review type:i18n

Comments

@pixelzoom
Copy link
Contributor

... similar to what was done in phetsims/natural-selection#319.
@pixelzoom pixelzoom self-assigned this Aug 30, 2022
@pixelzoom pixelzoom mentioned this issue Aug 30, 2022
Closed
@pixelzoom
Copy link
Contributor Author

This sim is next on the priority list, so labeling as high.

@pixelzoom
Copy link
Contributor Author

I published 1.3.0-dev.1 for brands=phet,phet-io as a baseline before starting this work.

pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
626e7f3
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
phetioVisiblePropertyInstrumented: false, #140
fb036b3
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
7d3b17f
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
a0ee7df
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
98e1eb9
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
211024e
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
bb1170a
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
0c76ed2
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
0c42561
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
1128a2d
pixelzoom added a commit that referenced this issue Aug 30, 2022
@pixelzoom
support for dynamic locale, #140
2dfdf43
pixelzoom added a commit that referenced this issue Aug 31, 2022
@pixelzoom
rework the color-key tandem hierarchy, #140
094889d
pixelzoom added a commit that referenced this issue Aug 31, 2022
@pixelzoom
TODOs for #140
ec4dcd1
@pixelzoom
Copy link
Contributor Author

Good progress on this today. Remaining work is indicated by TODO comments in the code.

pixelzoom added a commit that referenced this issue Aug 31, 2022
@pixelzoom
support for dynamic locale, #140
b732823
@pixelzoom pixelzoom mentioned this issue Aug 31, 2022
Closed
pixelzoom added a commit that referenced this issue Aug 31, 2022
@pixelzoom
rename labelText, #140
a05c5a9
pixelzoom added a commit that referenced this issue Aug 31, 2022
@pixelzoom
doc #140
8cd48d4
@pixelzoom pixelzoom mentioned this issue Sep 1, 2022
Closed
pixelzoom added a commit that referenced this issue Sep 1, 2022
@pixelzoom
support for dynamic locale #140
64ddb98
pixelzoom added a commit that referenced this issue Sep 1, 2022
@pixelzoom
support for dynamic locale #140, workaround for phetsims/scenery#1446
c2c58dc
pixelzoom added a commit that referenced this issue Sep 1, 2022
@pixelzoom
support for dynamic locale #140
616a451
@pixelzoom
Copy link
Contributor Author

@arouinfar this is ready for review. Unlike Natural Selection and Geometric, I did not instrument additional Text/RichText nodes, and all translated StringProperties are therefore not discoverable by inspecting Text/RichText elements in Studio. If you want additional Text/RichText instrumented, please identify them.

@pixelzoom pixelzoom assigned arouinfar and pixelzoom and unassigned pixelzoom and arouinfar Sep 1, 2022
@pixelzoom
Copy link
Contributor Author

Oops, I still have some layout work to do here. Assigning back to me.

pixelzoom added a commit that referenced this issue Sep 1, 2022
@pixelzoom
fix dynamic layout, #140
d5714e0
pixelzoom added a commit that referenced this issue Sep 1, 2022
@pixelzoom
fix dynamic layout, #140
5019d47
@pixelzoom
Copy link
Contributor Author

OK, ready for review.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Sep 1, 2022
@pixelzoom pixelzoom mentioned this issue Sep 9, 2022
Closed
@arouinfar
Copy link
Contributor

@pixelzoom I reviewed the tree in master, and things are looking good. I see linked properties back to StringProperties where I would expect, and the dynamic layout seems good.

The only odd case I found was the screen icons. The atom name can spill outside of the bounds in the iconic version, but that doesn't happen to the atoms in the play area.

image

@arouinfar arouinfar assigned pixelzoom and unassigned arouinfar Sep 12, 2022
pixelzoom added a commit that referenced this issue Sep 12, 2022
@pixelzoom
keep text centered in atoms for screen icons, #140
60ba90a
@pixelzoom
Copy link
Contributor Author

Fixed, back to @arouinfar to verify. Feel free to close if it looks OK.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Sep 12, 2022
@arouinfar
Copy link
Contributor

Thanks @pixelzoom, looks good!

image

pixelzoom added a commit that referenced this issue Dec 11, 2022
@pixelzoom
fix dynamic layout problem by using Panel instead of Plane, #140
e079ba0
pixelzoom added a commit that referenced this issue Dec 11, 2022
@pixelzoom
rename UnderDevelopmentPanel.ts, #140
124815a
pixelzoom added a commit that referenced this issue Dec 11, 2022
@pixelzoom
use VBox for layout of ElectronegativityPanel, #140
d803694
@pixelzoom
Copy link
Contributor Author

Commits above were incorrectly tagged for this issue, and should have been tagged for #141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:phet-io status:ready-for-review type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar