Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small lines appear at points of population graph #292

Closed
stemilymill opened this issue Jul 1, 2021 · 14 comments
Closed

Small lines appear at points of population graph #292

stemilymill opened this issue Jul 1, 2021 · 14 comments
Assignees
Labels
type:wontfix This will not be worked on

Comments

@stemilymill
Copy link

stemilymill commented Jul 1, 2021

Test device
Dell laptop & Surface

Operating System
Win10

Browser
Chrome 91.0.4472.124
(not able to reproduce on chrome os)

Problem description
For phetsims/qa#662
Occurs in published version and phet-io version.

As the population graph moves along, small lines briefly appear at the points of the graph, disappearing when the next stage of the generation clock enters the frame

Steps to reproduce
In either Intro or Lab screen, select traits and after a few generations, add environmental factors in order to create a stable population

For instance, summer + brown fur+ wolves + limited food
Or summer + brown fur +long teeth + wolves + tough food

The easiest and fastest way to observe the behavior is to hold fast forward button and not zoom the graph in, but the behavior appears in regular speed as well.

Visuals
natural selections little lines appear in pop graph

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Natural Selection‬
URL: https://phet.colorado.edu/sims/html/natural-selection/latest/natural-selection_en.html
Version: 1.3.1 2021-06-17 22:57:13 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36
Language: en-US
Window: 1418x688
Pixel Ratio: 1.3541666269302368/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@stemilymill stemilymill added the type:bug Something isn't working label Jul 1, 2021
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 1, 2021

This is undoubtedly a platform-specific graphics artifact, because there's nothing in the sim that is drawing these "small lines". PopulationPlotNode (extends Node) is responsible for rendering one plot. @jonathanolson any suggestions?

@jonathanolson
Copy link
Contributor

Initial hypothesis is that it's due to a browser not handling awkward cases correctly (perhaps there's a short almost-degenerate line? perhaps things are almost aligned but not?)

I'd either:

  1. Try rounding things to every 1e-5 units (or jittering by random small amounts), changing line cap/joins, etc., if it's a stroked path that's causing this.
  2. Try to inspect/reproduce a very specific path. Does it only happen while animating, or can we reproduce it to investigate statically? Then examine the path if so. Does it happen when paused?
  3. Search chromium bug tracker for similar bugs

Let me know if I should look into it directly.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 2, 2021

I am unable to reproduce this probem with Win10 and Chrome 91.0.4472.124 (the reported configuration). Here's my info from the "Report a Problem" menu item:

Troubleshooting information

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Natural Selection‬
URL: https://phet-dev.colorado.edu/html/natural-selection/1.4.0-rc.1/phet/natural-selection_all_phet.html
Version: 1.4.0-rc.1 2021-06-21 23:54:30 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36
Language: en-US
Window: 1037x814
Pixel Ratio: 2/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

  • @stemilymill does this problem go away if you resize your browser window? Does it occur with any other test configurations?

  • @jonathanolson are you able to reproduce this?

  • @amanda-phet is this issue blocking for the 1.4 release?

@stemilymill
Copy link
Author

@pixelzoom this still occurs when I resize the browser window, and I just replicated it in Edge 91.0.864.59 but have not replicated in any other config

@amanda-phet
Copy link
Contributor

I don't think this should be blocking, since it is not necessarily specific to this simulation. I have noticed some other artifact issues (in other sims) that I've been meaning to report, and wonder if they are related, and/or if there's anything to be done about them. I do think it's annoying, but shouldn't block this release.

@amanda-phet amanda-phet removed their assignment Jul 6, 2021
@jonathanolson
Copy link
Contributor

I'm not able to reproduce this on my Win10 + Chome 91.

@pixelzoom
Copy link
Contributor

@amanda-phet says this issue is not blocking. And @jonathanolson and I cannot reproduce it, so don't have an easy path to investigating. So I'm going to unassign and label this issue as deferred. Hopefully it will be addressed by future browser releases.

@pixelzoom pixelzoom removed their assignment Jul 13, 2021
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 13, 2022

Since we're doing a new release #309, and are in dev-testing phetsims/qa#818 ...

@KatieWoe could you have someone from QA check to see if this problem is still reproducible?

If it's still a problem, this issue is not necessary to address, and can simply be labeled deferred again. But if it's no longer reproducible, then this issue can be closed.

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jul 13, 2022

I was able to reproduce this problem in the PhET brand and PhET-iO standalone dev version 1.5 with Win10 + chrome. It doesn't happen with every generation. Many generations can pass (10-20) without me noticing any lines.
I'm going to try and reproduce with mac + chrome.
linePhETiOstandalone

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 13, 2022

Thanks @Nancy-Salpepi. Moving this issue back to "deferred", hoping it will resolve itself in a future browser release, or some other scenery fix. Also removing "bug" label, since it's just a graphics artifact that doesn't affect functionality or usability.

@pixelzoom pixelzoom added priority:5-deferred and removed type:bug Something isn't working labels Jul 13, 2022
@pixelzoom
Copy link
Contributor

Could someone from QA please test to see whether this is still a problem? I do not have a suitable test device. Please indicate the OS and Chrome versions that you used to test.

@KatieWoe
Copy link
Contributor

I wasn't able to reproduce it, but I'll let @Nancy-Salpepi take a look since she was able to reproduce it before.

@Nancy-Salpepi
Copy link

I still see the artifacts with Win10 + chrome 115, but very rarely. I'm not even sure if users would notice.
I don't think it is worth the time to explore fixing this, especially since @KatieWoe didn't see it with Win11.

@pixelzoom
Copy link
Contributor

Thanks @Nancy-Salpepi. This issue is not noticable, does not affect uability, and we're unlikely to address it. So I'm going to close this issue as "won't fix".

@pixelzoom pixelzoom added type:wontfix This will not be worked on and removed priority:5-deferred labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

6 participants