Shouldn't there be a limit to the number of 10 cards that can be used?

[Nancy-Salpepi]

Test device
MacBook Air M1 chip

Operating System
13.2.1

Browser
Safari

Problem description
For phetsims/qa#917, on the lab screen, there doesn't seem to be a limit to the number of 10 cards I can put in the play area. Shouldn't there be one?

Visuals

[chrisklus]

Thanks @Nancy-Salpepi, nice catch! @amanda-phet could you please comment how many ten frames we should allow? Based on the space available above, I'm thinking 10-12 maybe? After commenting, please reassign to @marlitas and @pixelzoom to implement at their convenience, whoever's up for it.

[marlitas]

Oooh mine!

[amanda-phet]

I agree, 10-12 seems the most reasonable for dev bounds (and I can't imagine a good pedagogical use beyond 10). Let's say 10.

Over to @marlitas to implement this change.

[marlitas]

Addressed in the above commits. I started by just eliminating pickability when we reached 10 Ten Frames. However this behavior seemed a bit confusing and remembered some other use cases where the draggable icon no longer appeared as though to indicate the stack ran out. I created a commit for that option as well.

Below are two videos showing both options. If the first option is preferred it would be very easy to revert the second commit where we toggle the icon's visibility.

Option 1: Limit pickability

Screen.Recording.2023-03-20.at.10.25.41.AM.mov

Option 2: Limit visiblity

Screen.Recording.2023-03-20.at.10.24.23.AM.mov

@amanda-phet & @chrisklus let me know your preference.

[chrisklus]

@marlitas and I paired on this. We decided to keep the visibility implementation because the rest of the items on this screen follow the same pattern. We also refactored TenFrameNode.getTenFramePath to take PathOptions so we could simplify the implementation by passing in a visibleProperty option that is a DerivedProperty. We think this is working as expected.

@Nancy-Salpepi can you please confirm on phettest? Feel free to close if looking good.

[Nancy-Salpepi]

Looks good! There are now 10 Ten Frames. The toolbox looks empty when all ten are in the play area and the icon reappears when one is returned.

Closing!