Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: Number Compare 1.0.0-dev.6 #917

Closed
8 of 13 tasks
chrisklus opened this issue Mar 9, 2023 · 4 comments
Closed
8 of 13 tasks

Dev Test: Number Compare 1.0.0-dev.6 #917

chrisklus opened this issue Mar 9, 2023 · 4 comments
Assignees
Labels
QA:dev-test Dev test before an RC
Projects

Comments

@chrisklus
Copy link

chrisklus commented Mar 9, 2023

Dev Test

Mentions: @kathy-phet, @amanda-phet, @pixelzoom, @marlitas

Simulation links

Test Matrix

Please include all (non-screen reader) feature testing in these records if applicable.

  • Latest macOS, Safari (Time = 4.25)
  • Windows 10, Chrome (Time = 2)
  • Windows 10, Firefox (Time = 2.5)
  • Latest iOS, Safari (Time = 2.5)
  • Windows 11, Chrome (Time =2.5 )

Light testing, or optionally skip if time crunch:

  • Latest macOS, Chrome (Time = 1.25)
  • Latest Chrome OS, Chrome (Time = 2)

Features included

  • PhET-iO
  • Alternative Input
  • UI Sound (Game sounds, and speech synthesis)
  • Sonification
  • Description
  • Voicing

Focus and Special Instructions

Please focus on various combinations of behavior involving a second language (under Preferences -> Simulation,
which adds a toggle to the first screen), the "Hear Number Sentence" control (under Preferences -> Audio), and changing the primary and secondary languages and voices. Please reach out to me for any clarification of how these features work.

phetsims/number-suite-common#44 is a known issue that will be completed before the next dev test.


For QA...

General features

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.
  • Check the Game Up harness on one platform.

PhET-iO features

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@chrisklus chrisklus added the QA:dev-test Dev test before an RC label Mar 9, 2023
@KatieWoe KatieWoe added this to Active Tests (max 5, by priority) in QA Pipeline Mar 9, 2023
@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 10, 2023

On Slack @chrisklus said:

hey all, Nancy Salpepi found that a key new voice feature is not working for the built version of Number Compare. I think we should pause this dev test while I do some refactoring to fix it.

@chrisklus
Copy link
Author

With phetsims/number-compare#20 and phetsims/number-suite-common#55 fixed, this dev test is good to continue. Thanks all for your patience.

@Nancy-Salpepi Nancy-Salpepi moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Mar 15, 2023
@KatieWoe
Copy link
Contributor

Calling QA here

@KatieWoe KatieWoe assigned chrisklus and unassigned KatieWoe Mar 20, 2023
@KatieWoe KatieWoe moved this from Active Tests (max 5, by priority) to Dev & RC: ready for next steps in QA Pipeline Mar 20, 2023
@zepumph zepumph self-assigned this Mar 23, 2023
@chrisklus
Copy link
Author

With the completion of most of the issues above and opening of #925, we are good to close here. Thanks everyone!

QA Pipeline automation moved this from Dev & RC: ready for next steps to Done Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
Status: Done
Development

No branches or pull requests

4 participants