Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic locale functionality #101

Closed
marlitas opened this issue Nov 17, 2023 · 4 comments
Closed

Add dynamic locale functionality #101

marlitas opened this issue Nov 17, 2023 · 4 comments
Assignees
@marlitas
Labels
status:ready-for-review

Comments

@marlitas
Copy link
Contributor

This issue will track the commits that convert NLO to support dynamic locale using dynamic layout
@marlitas marlitas self-assigned this Nov 17, 2023
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Convert strings to stringProperty for dynamicLocale, see: #101
2e43252
marlitas added a commit to phetsims/number-line-common that referenced this issue Nov 22, 2023
@marlitas
Convert strings to stringProperty for dynamicLocale, see: phetsims/nu…
d03142b 
…mber-line-operations#101
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Replace string.utils for NumberLineOperationNode.js, see: #101
9ac571f
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Replace string.utils for TotalValueAccordionBox.js, see: #101
307ebc2
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Replace string.utils for TotalValueIndicatorNode.js, see: #101
2d46d3c
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Replace stringUtils.fillIn for BalanceSheetItemNode.js, see: #101
0075bb1
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Replace stringUtils.fillIn for DynamicOperationDescription.js, see: #101
2ed9342
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Replace stringUtils.fillIn for NumericalExpressionAccordionBox.js, see:
802cd0c 
#101
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Remove interpolation from Text, see: #101
8ef4538
marlitas added a commit that referenced this issue Nov 22, 2023
@marlitas
Fix DynamicOperationDescription.js opacity and string result, see: #101
99a1797
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Allow typescript in repo, see: #101
73125b3
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Convert HoldingBagNode.js to typescript, see: #101
fa10c05
marlitas added a commit to phetsims/phet-info that referenced this issue Nov 27, 2023
@marlitas
Update typescript instructions, see: phetsims/number-line-operations#101
3ec27de
marlitas added a commit to phetsims/chipper that referenced this issue Nov 27, 2023
@marlitas
Convert HoldingBagNode.js to typescript, see: phetsims/number-line-op…
f3e45a2 
…erations#101
marlitas added a commit to phetsims/phet-info that referenced this issue Nov 27, 2023
@marlitas
Update caveats and notes, see: phetsims/number-line-operations#101
5241132
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Add maxWidth option for label, see: #101
334e83b
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Center valueIndicator label, see: #101
9414855
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Add dynamic layout to balance sheet item labels, see: #101
bb361b3
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Add dynamic layout to NumericalExpressionAccordionBox.js, see: #101
f60fe95
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Adjust maxWidths for InitialNetWorthAccordionBox.js, see: #101
cd5ae4f
marlitas added a commit that referenced this issue Nov 27, 2023
@marlitas
Center and size currency label for NetWorthIcon.js, see: #101
a5c7d95
@marlitas
Copy link
Contributor Author

This has been completed. Over to @amanda-phet to check on any layout or design concerns by using ?stringTest=dynamic or ?locales=*

@marlitas marlitas assigned amanda-phet and unassigned marlitas Nov 27, 2023
@amanda-phet
Copy link
Contributor

Discussed with @marlitas and we'll make the tags on the positive/negative and asset/debt bags the same for each screen, even though the words are different lengths, because the string lengths vary quite a bit between locales and it seems nice to just provide more room so fewer languages will need to shrink the text down.

@amanda-phet
Copy link
Contributor

Everything else was looking pretty good to me! QA will be more thorough but I tried to look through as much as I could think of.

@amanda-phet amanda-phet assigned marlitas and unassigned amanda-phet Nov 29, 2023
@marlitas
Copy link
Contributor Author

Great! I believe this issue can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amanda-phet @marlitas