Overlap issues with stringTest=dynamic

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
13.2.1

Browser
safari

Problem description
For phetsims/qa#925, with stringTest=dynamic:

1. On the Game Screen, it is possible for the info button to overlap the "Choose Your Game' statement.
2. On the Game Screen, it is possible for the "Choose Your Game" statement to go offscreen.
3. In the Preferences dialog, it is possible for the "Second Language" statement to overlap the "Subitize Time" statement.

Visuals

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Play‬ URL: https://phet-dev.colorado.edu/html/number-play/1.1.0-dev.10/phet/number-play_all_phet.html Version: 1.1.0-dev.10 2023-03-30 22:43:33 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.3 Safari/605.1.15 Language: en-US Window: 1185x705 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[zepumph]

Ok @chrisklus and I covered these cases, and went searching for a couple more. Please note that I updated the word accordion box string above so it should now update for the primary locale (which is at least helpful for i18n testing).

@Nancy-Salpepi will you take another pass at this both in the sim and in the preferences dialog.

@chrisklus will you please review the above commits.

[Nancy-Salpepi]

The two cases I reported look good. The word accordion box also looks good.
I found one more case:

[chrisklus]

Thanks @Nancy-Salpepi! I'm on it.

[zepumph]

We handled it in vegas, there was already good logic for maxWidths in the buttons, we just needed to extend it to the text too:

@Nancy-Salpepi want to double check that, and then close this issue. Then if you find anything else we can reopen here.

[Nancy-Salpepi]

This looks fixed in master.
Closing.