Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing is heard when switching voices in the localization tab #55

Closed
Nancy-Salpepi opened this issue Mar 10, 2023 · 3 comments
Closed
Assignees
Labels
type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
13.2.1

Browser
Safari

Problem description
While testing phetsims/qa#917, when changing the locale and voice in the Localization Tab of the Preferences Menu I didn't hear anything. Based on #52 (comment) and a slack conversation with @chrisklus, it was discovered that this feature was working in the unbuilt version but not working in 1.0.0-dev.4.

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Compare‬ URL: https://phet-dev.colorado.edu/html/number-compare/1.0.0-dev.4/phet/number-compare_all_phet.html Version: 1.0.0-dev.4 2023-03-09 16:37:22 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.3 Safari/605.1.15 Language: en-US Window: 1203x654 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Mar 10, 2023
chrisklus added a commit to phetsims/number-compare that referenced this issue Mar 15, 2023
chrisklus added a commit to phetsims/number-play that referenced this issue Mar 15, 2023
@chrisklus
Copy link
Contributor

Thanks @Nancy-Salpepi! I think this was actually caused by phetsims/number-compare#20, instead of phetsims/utterance-queue#108 like I was previously thinking. Leaving self assigned to verify in the new dev version.

@chrisklus
Copy link
Contributor

This appears to be fixed in dev.6, closing.

@chrisklus
Copy link
Contributor

Also, thanks to @zepumph for some great help on this issue. We refactored Number Play and Number Compare to use one announcer and utterance queue. I'm liking these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants