Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add four corner manipulation to Preview papers #92

Open
brettfiedler opened this issue May 10, 2023 · 4 comments
Open

Add four corner manipulation to Preview papers #92

brettfiedler opened this issue May 10, 2023 · 4 comments

Comments

@brettfiedler
Copy link
Contributor

[placeholder]

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 11, 2023

An initial commit for this has been added. Here is how it works:

  1. Each debug program has a cut button in the bottom left.
    image

  2. That breaks it into the four corners that can be dragged around like this:
    image

  3. The corner position for paper-land is at the center of each debug corner.

  4. The program can be removed by the close button in the top left corner.

  5. Resize and rotation is disabled when cut because those are now possible from moving individual corners (and it would be pretty tough to support cut + resize + rotation).

@BLFiedler over to you! Is this working as you expected and is there anyting you would like to change?

@brettfiedler
Copy link
Contributor Author

Awesome!

We might want to be able to reverse the process in the event someone accidentally clicks the scissors. Can keep it on the BL corner. Does that seem relatively simple to do? The other option of course is to close the program and bring it back in, so it's not gamebreaking.

Question: Does the actual position of the corner marker align with the very edge of the preview corner?
i.e.,
image

@jessegreenberg
Copy link
Contributor

OK, a button to recombine programs has been added. When you cut/recombine now it will reset corner positions relative to the top left corner and remove any rotation. That seemed like a reasonable behavior but let me know if it should change.

Does the actual position of the corner marker align with the very edge of the preview corner?

The actual position is at the center of each preview. That was just easiest because each debug corner could be positioned the same way. But it wouldn't be too hard to position each relative to its outer corner like that if that is best.

@brettfiedler
Copy link
Contributor Author

I think we will want to align the position with the outer corner to better match the paper papers. We'll try to stick to decisions like that to keep as much parity between them as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants