Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag dropper while it dispenses #86

Closed
KatieWoe opened this issue May 30, 2019 · 9 comments
Closed

Can't drag dropper while it dispenses #86

KatieWoe opened this issue May 30, 2019 · 9 comments
Labels

Comments

@KatieWoe
Copy link
Contributor

Test device:
Dell
Operating System:
Win 10 (or any)
Browser:
chrome (or any)
Problem description:
For phetsims/qa#323 and phetsims/qa#326.
In the published version of the sim you can activate the dropper and drag it around at the same time. You can do this with both the mouse and touch. In the rc, you can't drag the dropper while it is active with the mouse, but you can with touch. Nothing major, but it seems like an odd inconstancy.
Steps to reproduce:

  1. Go to a screen with a dropper
  2. Use the mouse to push and hold the button that starts the dropper
  3. While dispensing, try to move the dropper left and right.

Screenshots:
cantdrag

Troubleshooting information (do not edit):

Name: ‪pH Scale: Basics‬
URL: https://phet-dev.colorado.edu/html/ph-scale-basics/1.3.0-rc.1/phet/ph-scale-basics_all_phet.html
Version: 1.3.0-rc.1 2019-05-24 13:37:56 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 3, 2019

Reproduced with macOS 10.14.5 + Chrome latest, and it doesn't seem to be platform specific.

The implementation of PHDropperNode has not changed. My guess is the the toggle button on EyeDropperNode has a new-style input listener (PressListener) that is behaving differently and causing the drag listener (MovableDragHandler) not to get events. I'll need @jonathanolson's help on this.

@jonathanolson
Copy link
Contributor

The problem is that most drag/button listeners are set up so that they "attach" to the pointer, locking out other drag/button listeners from starting the interaction. This looks like a case where we want to enable that (e.g. to press attach:false to the button's PressListener).

There was no supported way to pass listeners to the created PressListener for buttons, so I added listenerOptions, and then added the flag in EyeDropperNode.

@pixelzoom can you test/review?

@jonathanolson jonathanolson removed their assignment Jun 3, 2019
@pixelzoom
Copy link
Contributor

Looks like this is working in master. @KatieWoe please verify, change to "fixed-awaiting-deploy" if it looks OK.

@KatieWoe
Copy link
Contributor Author

This looks good on master

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 17, 2019

Next step is to pick up:

pixelzoom pushed a commit to phetsims/scenery-phet that referenced this issue Jun 17, 2019
pixelzoom added a commit that referenced this issue Jun 17, 2019
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jun 17, 2019
@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 17, 2019

Patched in "ph-scale-1.3" branches for scenery-phet and sun, ready to test in upcoming 1.3.0-rc.2.

@pixelzoom
Copy link
Contributor

Talked with @jonathanolson. I should also create and patch "ph-scale-basics-1.3" branches for scenery-phet and sun.

@pixelzoom pixelzoom self-assigned this Jul 22, 2019
pixelzoom pushed a commit to phetsims/scenery-phet that referenced this issue Jul 23, 2019
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jul 23, 2019
@pixelzoom
Copy link
Contributor

Manually patched in "ph-scale-basics-1.3" branches for scenery-phet and sun.

@pixelzoom
Copy link
Contributor

Verified by QA in phetsims/qa#374 and phetsims/qa#375, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants