Automated maintenance release: interactive-description file rename #48

jessegreenberg · 2021-03-05T17:50:55Z

Perennial had a file called "interactive-descriptions" that was renamed to "interactive-description" for consistency. However, since phetmarks is versioned and perennial isn't this means that phetmarks is broken for sims with a phetmarks SHA prior to the rename.

In phetsims/a11y-research#157 (comment) and phetsims/a11y-research#157 (comment) we decided to use the automated maintenance release process to apply the rename commits to release branches so phetmarks works. We agreed that applying patches is sufficient for this and we don't need to actually republish sims. So I will go through the updateDependencies() step of the MR process and then stop there.

MR commits will be made against this issue, and I will document patch SHAs here.

The text was updated successfully, but these errors were encountered:

jessegreenberg · 2021-03-05T18:02:07Z

Here is the commit that renamed the file in phetmarks.js: b63edcd

jessegreenberg · 2021-03-05T18:46:49Z

Maintenance.addNeededPatchesBefore( "phetmarks", "b63edcd221cf883fc8c722361984fa0b96fab77d" ) reported that all release branches need this patch except

energy-skate-park-basics 1.4
circuit-construction-kit-dc 1.2
circuit-construction-kit-dc-virtual-lab 1.2

I expected recent branches like ratio-and-proportion to not need this, but I manually checked and indeed it does. energy-skate-park-basics 1.4 is quite old so I want to understand why the process skipped this one.

EDIT: It is because the most recent release branch of ESP:B is 1.1. 1.4 is unpublished AND for some reason does not have phetmarks in its dependencies.json. But 1.1 DOES have phetmarks in its dependencies, and the process did add a needed patch for energy-skate-park-basics 1.1.

jessegreenberg · 2021-03-05T19:07:07Z

Maintenance.applyPatches worked for zero release branches (which is a little surprising). So I checked out the first release in the list (acid-base-solutions 1.2) and saw that phetmarks is working OK. This is because the phetmarks SHA predates usage of perennial/data/accessibility (which was renamed to) perennial/data/interactive-descriptions (which was renamed to) perennial/data/interactive-description.

I need to find the commit that added perennial/data/accessibility to phetmarks and use Maintenance.removeNeededPatchesBefore() to remove many releases from the list.

EDIT: perennial/data/accessibility was added to phetmarks.js in 1044033. removeNeededPatchesBefore( "phetmarks", "104403355d0881e5cb4fd17af6b00482570049c8" ) removed about half of the releases, new list is

area-model-algebra 1.2 phet
  needs: phetmarks
area-model-decimals 1.2 phet
  needs: phetmarks
area-model-introduction 1.2 phet
  needs: phetmarks
area-model-multiplication 1.2 phet
  needs: phetmarks
atomic-interactions 1.2 phet
  needs: phetmarks
balancing-act 1.2 phet-io
  needs: phetmarks
balancing-chemical-equations 1.2 phet
  needs: phetmarks
balloons-and-static-electricity 1.4 phet
  needs: phetmarks
bending-light 1.1 phet
  needs: phetmarks
blackbody-spectrum 1.0 phet
  needs: phetmarks
build-a-fraction 1.0 phet
  needs: phetmarks
build-a-molecule 1.0 phet
  needs: phetmarks
capacitor-lab-basics 1.3-phetio phet-io
  needs: phetmarks
capacitor-lab-basics 1.6 phet,phet-io
  needs: phetmarks
capacitor-lab-basics 1.7 phet,phet-io (unreleased)
  needs: phetmarks
collision-lab 1.0 phet (unreleased)
  needs: phetmarks
collision-lab 1.1 phet (unreleased)
  needs: phetmarks
concentration 1.5-phetio phet-io
  needs: phetmarks
coulombs-law 1.0 phet
  needs: phetmarks
curve-fitting 1.0 phet
  needs: phetmarks
diffusion 1.0 phet
  needs: phetmarks
energy-forms-and-changes 1.4 phet,phet-io
  needs: phetmarks
energy-skate-park 1.1 phet
  needs: phetmarks
equality-explorer 1.0 phet
  needs: phetmarks
equality-explorer-basics 1.0 phet
  needs: phetmarks
equality-explorer-two-variables 1.0 phet
  needs: phetmarks
faradays-law 1.4 phet
  needs: phetmarks
fraction-matcher 1.2 phet
  needs: phetmarks
fractions-equality 1.1 phet
  needs: phetmarks
fractions-intro 1.0 phet
  needs: phetmarks
fractions-mixed-numbers 1.0 phet
  needs: phetmarks
friction 1.5 phet
  needs: phetmarks
gas-properties 1.0 phet
  needs: phetmarks
gases-intro 1.0 phet
  needs: phetmarks
graphing-lines 1.3 phet
  needs: phetmarks
graphing-quadratics 1.1 phet,phet-io
  needs: phetmarks
graphing-slope-intercept 1.1 phet
  needs: phetmarks
gravity-and-orbits 1.2 phet,phet-io (unreleased)
  needs: phetmarks
gravity-and-orbits 1.3 phet,phet-io (unreleased)
  needs: phetmarks
gravity-and-orbits 1.4 phet,phet-io (unreleased)
  needs: phetmarks
gravity-force-lab 2.2 phet,phet-io
  needs: phetmarks
gravity-force-lab-basics 1.0 phet
  needs: phetmarks
isotopes-and-atomic-mass 1.1 phet
  needs: phetmarks
john-travoltage 1.5 phet
  needs: phetmarks
masses-and-springs 1.0 phet
  needs: phetmarks
masses-and-springs-basics 1.0 phet
  needs: phetmarks
molarity 1.4 phet-io
  needs: phetmarks
molarity 1.5 phet
  needs: phetmarks
molecule-shapes 1.2 phet
  needs: phetmarks
molecule-shapes-basics 1.2 phet
  needs: phetmarks
molecules-and-light 1.5 phet
  needs: phetmarks
natural-selection 1.1 phet
  needs: phetmarks
natural-selection 1.2 phet-io
  needs: phetmarks
number-line-integers 1.0 phet
  needs: phetmarks
number-line-operations 1.0 phet
  needs: phetmarks
ohms-law 1.4 phet
  needs: phetmarks
ph-scale 1.3 phet
  needs: phetmarks
ph-scale 1.4 phet,phet-io (unreleased)
  needs: phetmarks
ph-scale-basics 1.3 phet
  needs: phetmarks
ph-scale-basics 1.4 phet,phet-io (unreleased)
  needs: phetmarks
ratio-and-proportion 1.0 phet (unreleased)
  needs: phetmarks
reactants-products-and-leftovers 1.2 phet
  needs: phetmarks
resistance-in-a-wire 1.6 phet
  needs: phetmarks
rutherford-scattering 1.1 phet
  needs: phetmarks
states-of-matter 1.2 phet,phet-io
  needs: phetmarks
states-of-matter-basics 1.2 phet,phet-io
  needs: phetmarks
vector-addition 1.0 phet
  needs: phetmarks
vector-addition-equations 1.0 phet
  needs: phetmarks
wave-interference 2.0 phet
  needs: phetmarks
waves-intro 1.0 phet
  needs: phetmarks
waves-intro 1.1 phet (unreleased)
  needs: phetmarks
[phetmarks] https://github.com/phetsims/phetmarks/issues/48
  b63edcd221cf883fc8c722361984fa0b96fab77d
    area-model-algebra 1.2 phet
    area-model-decimals 1.2 phet
    area-model-introduction 1.2 phet
    area-model-multiplication 1.2 phet
    atomic-interactions 1.2 phet
    balancing-act 1.2 phet-io
    balancing-chemical-equations 1.2 phet
    balloons-and-static-electricity 1.4 phet
    bending-light 1.1 phet
    blackbody-spectrum 1.0 phet
    build-a-fraction 1.0 phet
    build-a-molecule 1.0 phet
    capacitor-lab-basics 1.3-phetio phet-io
    capacitor-lab-basics 1.6 phet,phet-io
    capacitor-lab-basics 1.7 phet,phet-io
    collision-lab 1.0 phet
    collision-lab 1.1 phet
    concentration 1.5-phetio phet-io
    coulombs-law 1.0 phet
    curve-fitting 1.0 phet
    diffusion 1.0 phet
    energy-forms-and-changes 1.4 phet,phet-io
    energy-skate-park 1.1 phet
    equality-explorer 1.0 phet
    equality-explorer-basics 1.0 phet
    equality-explorer-two-variables 1.0 phet
    faradays-law 1.4 phet
    fraction-matcher 1.2 phet
    fractions-equality 1.1 phet
    fractions-intro 1.0 phet
    fractions-mixed-numbers 1.0 phet
    friction 1.5 phet
    gas-properties 1.0 phet
    gases-intro 1.0 phet
    graphing-lines 1.3 phet
    graphing-quadratics 1.1 phet,phet-io
    graphing-slope-intercept 1.1 phet
    gravity-and-orbits 1.2 phet,phet-io
    gravity-and-orbits 1.3 phet,phet-io
    gravity-and-orbits 1.4 phet,phet-io
    gravity-force-lab 2.2 phet,phet-io
    gravity-force-lab-basics 1.0 phet
    isotopes-and-atomic-mass 1.1 phet
    john-travoltage 1.5 phet
    masses-and-springs 1.0 phet
    masses-and-springs-basics 1.0 phet
    molarity 1.4 phet-io
    molarity 1.5 phet
    molecule-shapes 1.2 phet
    molecule-shapes-basics 1.2 phet
    molecules-and-light 1.5 phet
    natural-selection 1.1 phet
    natural-selection 1.2 phet-io
    number-line-integers 1.0 phet
    number-line-operations 1.0 phet
    ohms-law 1.4 phet
    ph-scale 1.3 phet
    ph-scale 1.4 phet,phet-io
    ph-scale-basics 1.3 phet
    ph-scale-basics 1.4 phet,phet-io
    ratio-and-proportion 1.0 phet
    reactants-products-and-leftovers 1.2 phet
    resistance-in-a-wire 1.6 phet
    rutherford-scattering 1.1 phet
    states-of-matter 1.2 phet,phet-io
    states-of-matter-basics 1.2 phet,phet-io
    vector-addition 1.0 phet
    vector-addition-equations 1.0 phet
    wave-interference 2.0 phet
    waves-intro 1.0 phet
    waves-intro 1.1 phet

EDIT2: After iterating over creating and applying patches to the above list, I determined a few more did not need this change because their phetmarks SHA did not include phetmarks.js. I am not clear why the process identified these branches as needing the patch. But the final list of branches whose dependencies will be updated is

maintenance> Maintenance.list()
area-model-algebra 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 8942314e2cc78c45246515636f0916add1e34563
area-model-decimals 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 751cd9a4548ba638efea8ede241409a01abe2c77
area-model-introduction 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 751cd9a4548ba638efea8ede241409a01abe2c77
area-model-multiplication 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 751cd9a4548ba638efea8ede241409a01abe2c77
atomic-interactions 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: eb19ef45c516b07c8cb03373751d59a41092a702
balancing-act 1.2 phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 339f179da4ac7c3cdf9a6019ad7cc93a4366814c
balancing-chemical-equations 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: a0ab209e8bbe013afea92b3952cfe6a828b4302f
balloons-and-static-electricity 1.4 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 0f75f47fe49bccb0df60f46bddfaf1b034a40cd7
blackbody-spectrum 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 661c79796b764d6dbd30cec45fade65c5cbd3bd4
build-a-fraction 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 5d94d449827538950fd7a048c58ab823b0329594
build-a-molecule 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: a4278a1fa5d87e302f395278e49c849c325eb344
capacitor-lab-basics 1.6 phet,phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 6a9d475e657afc428dd8f90af755fe85ad18e960
capacitor-lab-basics 1.7 phet,phet-io (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 0f63740f3a7f86e730143134a69d373e5fef5dc5
collision-lab 1.0 phet (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 7d869dff1eadf203ff2ac0f701228eb59024d16b
collision-lab 1.1 phet (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 2adb68104d76b633d3675d052db990cbb1b964c6
coulombs-law 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 04eac1cd20f3cb45ea11d945d3c51a643b4a5b09
curve-fitting 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: d5359098231ff598f3864cdcaa12369c318e23f8
diffusion 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: c63fc479a616d48d2dd7db54be664c8880f27bb5
energy-forms-and-changes 1.4 phet,phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 5960ce73eaa3cf0c6cb81c009ebff48aae5b8458
energy-skate-park 1.1 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 5960ce73eaa3cf0c6cb81c009ebff48aae5b8458
equality-explorer 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 3091ec1d50b21946797370d99315503814be64e6
equality-explorer-basics 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 34af1ad22076f93de59c0beed157bb14291e9671
equality-explorer-two-variables 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 34af1ad22076f93de59c0beed157bb14291e9671
faradays-law 1.4 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 3d11f9036e44039a98aa2d653c447fe79e92aec6
fraction-matcher 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 84fcdbe5ea9d128e816e221146202d4006278151
fractions-equality 1.1 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 84fcdbe5ea9d128e816e221146202d4006278151
fractions-intro 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: f105a42a80722c77966508bd137c7ffe278b216e
fractions-mixed-numbers 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 7505ec68bbed6e2a6f67957a96a20ad9dfa04013
friction 1.5 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 4ea10cfb633c91e6bf0c34575a418650108013f9
gas-properties 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 73f44a7aecea34b9121b2f1775e7230a8533035a
gases-intro 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 721874d5650dc4f90e6844b4e91f977f8441d089
graphing-lines 1.3 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 81aa1dead75661b1c77d740a9d2ec4007ad204a6
graphing-quadratics 1.1 phet,phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: a19ff9aaf6c482ca273ad555287d40ea955d5346
graphing-slope-intercept 1.1 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 37733964388621497dcb5fe94c1c6a48d36aa4e9
gravity-and-orbits 1.2 phet,phet-io (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: b63d2510fc21b616815a343b615d13a113eb5f94
gravity-and-orbits 1.3 phet,phet-io (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 889224ba55a35501cbf72f78ad2fe20e238cc832
gravity-and-orbits 1.4 phet,phet-io (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 486a9931e7aa465b54b206d53f749e8d4cb0c5bd
gravity-force-lab 2.2 phet,phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: c50856f93447eccdfd9def8ffe988fb9251034fa
gravity-force-lab-basics 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: b76a2541feaaf29a498f7c9f71a35f73ec7b49a9
isotopes-and-atomic-mass 1.1 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: fc7d5d2b43f7a3e7cb9e8fff86382384eb6e5d7f
john-travoltage 1.5 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: ff3d458040d0b37abc797dc5efc5ee1d602d0f00
masses-and-springs 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 85b7b13ddc6834b64fe3dfe77b6a75305134ce73
masses-and-springs-basics 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 6f572d705df0ce377b4077758af1fa4876b37498
molarity 1.4 phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 6deb6a5bdb242dbefe34ab4787e728a7eb35f2b9
molarity 1.5 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: e90716ee815a37eb13fa8a7c3a477160adf50b1d
molecule-shapes 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 43918c4260c39e833228699800945c14b32e4bb9
molecule-shapes-basics 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 8117a1372803091565ce4031928ae7b3326c7371
molecules-and-light 1.5 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 4e339268ff4bde92671940a447a033a8e49e9bef
natural-selection 1.1 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: b3ffbf895e6c588ec2dc8e1b38df780d9cb75285
natural-selection 1.2 phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: d4ae91e0f5054f8819650050331ed86970f1f4fc
number-line-integers 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 692de9b425a0216731644628c92f680bc824c9c8
number-line-operations 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 08ccaf0aaf72745836eb887b77e63de50a1176f7
ohms-law 1.4 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 991f1a1fb9e68096d3f0c9c31017a8a953cd4ce5
ph-scale 1.3 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 991f1a1fb9e68096d3f0c9c31017a8a953cd4ce5
ph-scale 1.4 phet,phet-io (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 616eb4864c397546422f35c713db3a167f773a03
ph-scale-basics 1.3 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 82adb8e5fde16a06fb6588f58d86d069cea42a7a
ph-scale-basics 1.4 phet,phet-io (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 616eb4864c397546422f35c713db3a167f773a03
ratio-and-proportion 1.0 phet (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: acb3e0e7cbfb22b1985755cef1bf0746dfb32d8d
reactants-products-and-leftovers 1.2 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: b8104e5e5cab630d7a5ca53b7f49a20c2a8e4db5
resistance-in-a-wire 1.6 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 58a403c7e91bbe66486ac8cc174ddba0a305c671
rutherford-scattering 1.1 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 1ac26ce3cd592f5b591a1e426f128a29267c53fb
states-of-matter 1.2 phet,phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: ebe1ab6075168b7274bc89b86f6ea4842c3c479b
states-of-matter-basics 1.2 phet,phet-io
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 3d46184ac992afb6ae6590d528826ec7e3405095
vector-addition 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: dd3d828ebbf48dc84b59bda5a4f76a0f7f716870
vector-addition-equations 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: dd3d828ebbf48dc84b59bda5a4f76a0f7f716870
wave-interference 2.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 32b7d0cb348183e18fcc1ae3b59def9662e38194
waves-intro 1.0 phet
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: 32b7d0cb348183e18fcc1ae3b59def9662e38194
waves-intro 1.1 phet (unreleased)
  pendingMessages: https://github.com/phetsims/phetmarks/issues/48
  deps:
    phetmarks: a9ba7a03d537e174108449dca85ce398117b53b2
[phetmarks] https://github.com/phetsims/phetmarks/issues/48
  b63edcd221cf883fc8c722361984fa0b96fab77d
  c1c7c2da23794ef2e8e5ea5d83aa0e49ff705ddf
  ec35a8495e8d36bfc0f2153c465d98dc6bbad142
  eef97d27931068dbc1aba3d5c8b12445800d982b

jessegreenberg · 2021-03-08T17:38:03Z

Hit a build error while running Maintenance.updateDependencies:

Checked out capacitor-lab-basics 1.7
Branch capacitor-lab-basics-1.7 does not exist in phetmarks, creating.
Maintenance task failed:
Error: Failure updating dependencies for capacitor-lab-basics to 1.7: Error: grunt.cmd --brands=phet,phet-io --locales=en --allHTML --debugHTML in ../capacitor-lab-basics failed with exit code 1 and stdout:
Running "lint-all" task

Running "report-media" task

Running "clean" task

Running "build" task
Building runnable repository (capacitor-lab-basics, brands: phet, phet-io)
Building brand: phet
>> require.js optimization for brand: phet complete (4523505 bytes)
>> Minification for phet complete
>> Require.js: 1350177 bytes
>> Preloads: 248047 bytes
>> Mipmaps: 88582 bytes
Building brand: phet-io
>> require.js optimization for brand: phet-io complete (4646715 bytes)
>> Minification for phet-io complete
>> Require.js: 1389252 bytes
>> Preloads: 594130 bytes
>> Mipmaps: 66550 bytes
Fatal error: error executing binary "node": Error: node ../chipper/node_modules/jsdoc/jsdoc.js ../phet-io-wrappers/common/js/Client.js ../tandem/js/PhetioIDUtils.js ../phet-io/js/phet-io-initialize-globals.js ../chipper/js/initialize-globals.js -c ../phet-io/doc/wrapper/jsdoc-config.json -d ../capacitor-lab-basics/build/phet-io/doc/ --readme ../phet-io/doc/wrapper/phet-io-documentation_README.md in C:\Users\Jesse\Documents\Development\phetsims-secondary\capacitor-lab-basics failed with exit code 1 and stdout:


    at Function.updateDependencies (C:\Users\Jesse\Documents\Development\phetsims-secondary\perennial\js\common\Maintenance.js:755:17)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Full Error details:
{}

jessegreenberg · 2021-03-08T17:55:22Z

On a different machine (without local commits for this issue) when I checkout capacitor-lab-basics 1.7 branch and dependencies.json SHAs (with npm update in sim and chipper) and run grunt --brands=phet-io I get the same error.

@samreid or @zepumph would you mind taking a look or recommending how to proceed?

I am going to temporarily remove capacitor-lab-basics 1.7 from maintenance.json and continue with Maintenance.updateDependencies() for now.

EDIT: Removed capacitor-lab-basics 1.7 entry for safe keeping:

    {
      "releaseBranch": {
        "repo": "capacitor-lab-basics",
        "branch": "1.7",
        "brands": [
          "phet",
          "phet-io"
        ],
        "isReleased": false
      },
      "changedDependencies": {},
      "neededPatches": [],
      "pendingMessages": [
        "https://github.com/phetsims/phetmarks/issues/48"
      ],
      "pushedMessages": [],
      "deployedVersion": null
    },

zepumph · 2021-03-08T18:00:47Z

I'll take a look.

zepumph · 2021-03-08T18:13:15Z

The most recent CLB version published for PhET-iO is 1.6. How was phet-io brand added to 1.7 as a supported brand by the MR process? I look at the phet-io deploy status as well as the master phet-io spreadsheet and neither have 1.7 on it? I see 1.7 is not currently published for either brand (last RC was phetsims/qa#588), but dev test on the way? (phetsims/qa#616).

Over to JO with two questions:

How do we make sure phet-io isn't attempted to be published on branches that don't support it?
Is CLB being published with PhET-iO? Because I didn't think so.

jessegreenberg · 2021-03-08T20:57:52Z

this MR won't be published, but will just get shas on their branches? If that is the case couldn't we perhaps just each phet-io brand to phet (if not already covered)

That is correct, these are not being republished. Sorry, do what for each phet-io brand?

zepumph · 2021-03-08T20:59:55Z

If the entries you are removing are specific to phet-io brand, but in a branch that is getting a phet brand MR also, then can't we just remove them anyways and the phet MR updateDependencies call will patch the dependencies.json like we need to for all brands?

jessegreenberg · 2021-03-08T21:08:29Z

Ah, yes - that could work. The only exception so far is molarity 1.4 which only has phet-io brand (entry in #48 (comment)). phet brand is published at 1.5.

jessegreenberg · 2021-03-08T21:11:04Z

So what I would do is add the removed entries back into maintenance.json, but remove the "phet-io" from the brands array in #48 (comment) (for example).

jessegreenberg · 2021-03-08T21:15:45Z

OK, updatedDependencies is complete. Sims that failed were
capacitor-lab-basics 1.7 (phet, phet-io)
graphing-quadratics 1.1 (phet, phet-io)
molarity 1.4 (phet-io)

jessegreenberg · 2021-03-08T21:33:09Z

I tried #48 (comment) but I am not able to run updateDependencies for the sims that failed. All I get is Dependencies updated in the console. I think what is happening is that the MR process removed the changedDependencies before the failure, so the process thinks everything succeeded. Here is the entry for graphing-quadratics at 10:59 am on my local machine:

    {
      "releaseBranch": {
        "repo": "graphing-quadratics",
        "branch": "1.1",
        "brands": [
          "phet",
          "phet-io"
        ],
        "isReleased": true
      },
      "changedDependencies": {
        "phetmarks": "a19ff9aaf6c482ca273ad555287d40ea955d5346"
      },
      "neededPatches": [],
      "pendingMessages": [
        "https://github.com/phetsims/phetmarks/issues/48"
      ],
      "pushedMessages": [],
      "deployedVersion": null
    },

Against the same entry after the failure:

    {
      "releaseBranch": {
        "repo": "graphing-quadratics",
        "branch": "1.1",
        "brands": [
          "phet",
          "phet-io"
        ],
        "isReleased": true
      },
      "changedDependencies": {},
      "neededPatches": [],
      "pendingMessages": [
        "https://github.com/phetsims/phetmarks/issues/48"
      ],
      "pushedMessages": [],
      "deployedVersion": null
    },

EDIT: Keeping track of the same data for molarity 1.4 and capacitor-lab-basics 1.7 so I can try those again too:
molarity 1.4:

    {
      "releaseBranch": {
        "repo": "molarity",
        "branch": "1.4",
        "brands": [
          "phet-io"
        ],
        "isReleased": true
      },
      "changedDependencies": {
        "phetmarks": "6deb6a5bdb242dbefe34ab4787e728a7eb35f2b9"
      },
      "neededPatches": [],
      "pendingMessages": [
        "https://github.com/phetsims/phetmarks/issues/48"
      ],
      "pushedMessages": [],
      "deployedVersion": null
    },

capacitor-lab-basics 1.7:

    {
      "releaseBranch": {
        "repo": "capacitor-lab-basics",
        "branch": "1.7",
        "brands": [
          "phet",
          "phet-io"
        ],
        "isReleased": false
      },
      "changedDependencies": {
        "phetmarks": "0f63740f3a7f86e730143134a69d373e5fef5dc5"
      },
      "neededPatches": [],
      "pendingMessages": [
        "https://github.com/phetsims/phetmarks/issues/48"
      ],
      "pushedMessages": [],
      "deployedVersion": null
    },

jessegreenberg · 2021-03-08T21:53:12Z

Removing brand phet-io brand and adding back the changedDependencies made it work. So I think all that is left for this is to

Decide what to do about molarity 1.4 phet-io? That branch is only phet-io brand and could not build so depenencies were not updated.
Create a new issue about how updateDependencies removed changedDependencies before a failure to update, so the process thought it was successful (see Automated maintenance release: interactive-description file rename #48 (comment))
Create a new issue about how the MR process is trying to update/redeploy phet-io brand when it shouldn't (see Automated maintenance release: interactive-description file rename #48 (comment))
Create a new issue to investigate the build issue for phet-io sims.

@zepumph do you have any thoughts about 1 above and do the others seem reasonable?

zepumph · 2021-03-08T21:59:22Z

Yes that is excellent. Please assign me on all of them. but (2) (JO)

jessegreenberg · 2021-03-08T22:24:47Z

OK sounds great! Issues have been opened. Leaving you assigned here for the last part.

Decide what to do about molarity 1.4 phet-io? That branch is only phet-io brand and could not build so depenencies were not updated.

zepumph · 2021-03-08T23:58:33Z

molarity 1.4 has been patched. Anything else here?

jessegreenberg · 2021-03-09T00:31:30Z

Thats it, thanks @zepumph - closing.

jessegreenberg self-assigned this Mar 5, 2021

samreid mentioned this issue Mar 5, 2021

User suggestion: standardize schematic components phetsims/circuit-construction-kit-common#429

Closed

jessegreenberg added a commit to phetsims/area-model-algebra that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

25f7e0d

jessegreenberg added a commit to phetsims/area-model-decimals that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

1ae6e7b

jessegreenberg added a commit to phetsims/area-model-introduction that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

d3ed1b6

jessegreenberg added a commit to phetsims/area-model-multiplication that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

1e71c30

jessegreenberg added a commit to phetsims/atomic-interactions that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

a8ca975

jessegreenberg added a commit to phetsims/balancing-act that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

54adef3

jessegreenberg added a commit to phetsims/balancing-chemical-equations that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

4d092aa

jessegreenberg added a commit to phetsims/balloons-and-static-electricity that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

9900978

jessegreenberg added a commit to phetsims/blackbody-spectrum that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

3bcedf4

jessegreenberg added a commit to phetsims/build-a-fraction that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

b55d40d

jessegreenberg added a commit to phetsims/build-a-molecule that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

0c851c9

jessegreenberg added a commit to phetsims/capacitor-lab-basics that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

8a8d328

jessegreenberg assigned samreid and zepumph Mar 8, 2021

jessegreenberg added a commit to phetsims/collision-lab that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

183dc16

jessegreenberg added a commit to phetsims/collision-lab that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

432195e

jessegreenberg added a commit to phetsims/coulombs-law that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

2bcf209

jessegreenberg added a commit to phetsims/curve-fitting that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

baf83e9

jessegreenberg added a commit to phetsims/diffusion that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

021c8cf

jessegreenberg added a commit to phetsims/energy-forms-and-changes that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

b93e6f2

zepumph unassigned samreid Mar 8, 2021

jessegreenberg added a commit to phetsims/states-of-matter-basics that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

803ff8e

jessegreenberg added a commit to phetsims/vector-addition that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

09af24d

jessegreenberg added a commit to phetsims/vector-addition-equations that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

075029b

jessegreenberg added a commit to phetsims/wave-interference that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

6bf49b9

jessegreenberg added a commit to phetsims/waves-intro that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

874566c

jessegreenberg added a commit to phetsims/waves-intro that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

6f0de10

jessegreenberg added a commit to phetsims/capacitor-lab-basics that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

5aedaf0

jessegreenberg added a commit to phetsims/graphing-quadratics that referenced this issue Mar 8, 2021

updated dependencies.json for phetsims/phetmarks#48

3df74a3

This was referenced Mar 8, 2021

MR process: Maintenance.updateDependencies may be clearing changedDependencies too soon phetsims/perennial#214

Open

Automated maintenance process may be deploying phet-io brand when it shouldn't phetsims/perennial#215

Closed

jessegreenberg unassigned jonathanolson and jessegreenberg Mar 8, 2021

jessegreenberg mentioned this issue Mar 8, 2021

Rename "Interactive Descriptions" to "Interactive Description" across the project phetsims/a11y-research#157

Closed

zepumph added the priority:2-high label Mar 8, 2021

zepumph added a commit to phetsims/molarity that referenced this issue Mar 8, 2021

update dependencies for molarity 1.4, phetsims/phetmarks#48

61bde0b

zepumph assigned jessegreenberg and unassigned zepumph Mar 8, 2021

zepumph removed the priority:2-high label Mar 8, 2021

jessegreenberg closed this as completed Mar 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automated maintenance release: interactive-description file rename #48

Automated maintenance release: interactive-description file rename #48

jessegreenberg commented Mar 5, 2021 •

edited

Loading

jessegreenberg commented Mar 5, 2021

jessegreenberg commented Mar 5, 2021 •

edited

Loading

jessegreenberg commented Mar 5, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021 •

edited

Loading

zepumph commented Mar 8, 2021

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021 •

edited

Loading

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 9, 2021

Automated maintenance release: interactive-description file rename #48

Automated maintenance release: interactive-description file rename #48

Comments

jessegreenberg commented Mar 5, 2021 • edited Loading

jessegreenberg commented Mar 5, 2021

jessegreenberg commented Mar 5, 2021 • edited Loading

jessegreenberg commented Mar 5, 2021 • edited Loading

jessegreenberg commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021 • edited Loading

zepumph commented Mar 8, 2021

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021 • edited Loading

jessegreenberg commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021 • edited Loading

jessegreenberg commented Mar 8, 2021 • edited Loading

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 8, 2021

zepumph commented Mar 8, 2021

jessegreenberg commented Mar 9, 2021

jessegreenberg commented Mar 5, 2021 •

edited

Loading

jessegreenberg commented Mar 5, 2021 •

edited

Loading

jessegreenberg commented Mar 5, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021 •

edited

Loading

jessegreenberg commented Mar 8, 2021 •

edited

Loading