Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create general Properties to control the displayOnlyProperty for all NumberControls #270

Open
zepumph opened this issue Jul 29, 2021 · 3 comments
Open

Create general Properties to control the displayOnlyProperty for all NumberControls #270

zepumph opened this issue Jul 29, 2021 · 3 comments
Labels
dev:phet-io status:on-hold

Comments

@zepumph
Copy link
Member

zepumph commented Jul 29, 2021

Basically identical to #260, but I believe this needs to be put on hold until phetsims/sun#686 is sorted out.
@zepumph zepumph self-assigned this Jul 29, 2021
@zepumph zepumph mentioned this issue Jul 29, 2021
Closed
zepumph added a commit that referenced this issue Aug 16, 2021
@zepumph
create Properties to control displayOnly of every diameter control an…
3cab18c 
…d every mass too, #270
zepumph added a commit to phetsims/scenery-phet that referenced this issue Aug 16, 2021
@zepumph
create Properties to control displayOnly of every diameter control an…
b3963e8 
…d every mass too, phetsims/projectile-motion#270
@zepumph
Copy link
Member Author

zepumph commented Aug 16, 2021

Implemented above. @arouinfar please review

@zepumph zepumph assigned arouinfar and unassigned zepumph Aug 16, 2021
@zepumph
Copy link
Member Author

zepumph commented Aug 31, 2021 •
edited
Loading

Over in phetsims/sun#686 (comment) we decided against the current implementation of NumberControl.displayOnlyProperty, so I'm going to revert and mark on hold until we have a new solution in phetsims/sun#714

@zepumph zepumph assigned zepumph and unassigned arouinfar Aug 31, 2021
zepumph added a commit that referenced this issue Aug 31, 2021
@zepumph
Revert "create Properties to control displayOnly of every diameter co…
ff785f6 
…ntrol and every mass too, #270"

This reverts commit 3cab18c.
@zepumph
Copy link
Member Author

zepumph commented Aug 31, 2021

In PhET-iO meeting 8/26/21, we decided that NumberControl.displayOnlyProperty should not block PM publication for PhET-iO.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io status:on-hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @arouinfar