Flip the Object and Context Responses around

[terracoda]

As discussed in the design meeting on Tuesday, we want to try and flip the object responses and context responses around for the hand interactions.

Reason, we like the order of the information when Lock Ratio check box is checked , and in that case, proximity to ratio is the value for the object responses.

I've sketched out an example CWT for the Both Hands interaction in this table in the design document.

The sliders will be similar, and in the case of the sliders there are also "distance progress indicators".

A few issues ago, I took the progress indicators out of the both hands interaction, but with the information flipped around, it might make sense to put them back. @zepumph, please do whatever is most straight forward, and then I can test and we can discuss.

[zepumph]

@terracoda asked me not to do this until she could have a listen to some of the other changes I made in the description. @terracoda let me know when we are ready for this.

[terracoda]

@zepumph, I made a table with a small test of the Left hand slider with the design flipped

I think it is safe to flip the design.

[terracoda]

My test was applying the new logic, but we can discuss the logic before or after the flip - whatever makes sense to you.

[terracoda]

Oops, forgot to re-assign to you, @zepumph.

When you do this, I see 3 parts to the flip:

1. Both Hands - looks like a direct flip since the ratio responses are currently on their own in context responses - rough examples in this table in the design doc
2. Sliders - not a direct flip, since ratio responses are combined with distance (and progress) in context responses
3. Adjustment of the current logic that replaces context responses with distance progress responses

Do you see it this way as well @zepumph?

[terracoda]

@zepumph, I'll create separate issues numbers 2 and 3 above, in case that is helpful.
This issue can be for number 1.

[zepumph]

This should be implemented, please review @terracoda.

[zepumph]

When you review this, know that all flipping logic from side-issues (#261 and #262) has also been implemented.

[terracoda]

with ratio locked, Moving hands down

with ratio locked, Moving hands up

[terracoda]

@zepumph, I don't seem to get distance-progress if I have focus on a slider and ratio is locked. Here are three consecutive steps going up in the same distance region.

[terracoda]

Last comment is more appropriate for issue #262, maybe.

[terracoda]

Oh, last 2 comments, #245 (comment) and #245 (comment)

maybe these comments should go in #262?
Anyways, this issue is connect to #261 and #262

[zepumph]

From the design meeting today, @terracoda reiterated two bugs with the current implementation:

• The distance-progress isn't working when ratio is locked
• When using both-hands, the distance-progress is often (always!?!) backwards.

[zepumph]

The distance-progress isn't working when ratio is locked

This was fixed in 65abe56 by making sure that we only calculate the distance changed when we create the description. Before it was in a listener and could change multiple times before needing a value of "closer" or "farther", and it would be stale. This should be fixed now.

[zepumph]

@terracoda, I believe that both bugs are fixed. I at least think it is ready for another review. Good luck!

[terracoda]

Ok, cool.

[terracoda]

• closer/farther distance progress responses is no working for Both Hands with Lock Ratio checked.
• with the hands unlocked, the Both Hands is getting distance progress responses

[terracoda]

I still need to check with the tick marks, but don't anticipate issues.

[terracoda]

• the distance progress is working with the tick marks on.

With ratio locked, it seems when the left hand is visually "on a tick mark", it described as being "around" to tick mark.

Here's 2 screen shots. Not sure if this is directly related to this issue, but since I am testing this issue, I just need to post it here before I lose my train of thought:

[terracoda]

Double checking with Lock Ratio unchecked.
Ok, this seems to happen only with Lock Ratio checked.

I can start out with Both Hands at 1:3 with each on the correct tick mark, but by the time the Left Hand gets to Tick Mark 2, the descriptions says "around tick mark 2" with right hand "on tick mark 6".

Also, if I start out at 1:3 and then move the hands down as far as they can go with ratio locked, and then move back up again, the left hand is described as "around tick mark 1" when it visually gets back on 1.

[terracoda]

I commented over in #209 (comment) just in case the above comments should be in that issue.

[terracoda]

@zepumph, in principle the correct object and context responses are firing for Both Hands.
The actual position of the left hand can become askew when ratio is locked.

Shall we work on that more in issue #209?
Assigning to you for closing.

[zepumph]

I created #279 for that bug. It sounds like this issue about flipping responses is done. Closing