-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translators are reporting incorrect percentages in the report #421
Comments
I can see what they are talking about. If I look at Kikuyu for acid-base-solutions I see this: But when I load the translation page for the sim, all but one string is translated. It also lists the sim as "not yet published in Kikuyu", and I don't see it on the website. @solaolateju - Can you please ask the translator if they have published the sim by pressing the "Publish" button? Perhaps they are using the translation a little differently or something. If they haven't, please have them do so. |
We have known for some time that the % Translated Strings is not accurate. This does not prevent the publication. And yes, our translators keep pressing "Publish" and it's just not showing up on the website. We have noted this issue in Shona and Kikuyu. |
Screenshot: Acid-base solutions Sorry @jbphet, this notification got drowned in all the GitHub notifications. Yes, they hit the publish button. I also tested with Kikuyu. When you hit the publish button, you receive the regular prompt before submission that shows all the strings are translated. Followed by a confirmation of submission. However, the submitted sim stays in the list of "Sims not yet published" and cannot be viewed on the website. |
I just checked the main PhET website and found that the Kikuyu translation of Acid Base solutions is present. I looked at the history of the main translation strings file ( I think this particular sim/locale is now looking correct, and I'll pursue some of the other issues with mis-reported stats. |
@solaolateju - I just looked at the stats for the Kikuyu translations of greenhouse-effect, build-a-molecule, and acid-base-solutions, which were identified at one point as being incorrect. They all look correct to me. Can you please check and/or have the Kikuyu translator check and see if these issues appear to be resolved? |
@RVieyra said in a previous comment:
I've tracked down and, I believe, fixed a couple of issue that were causing inaccuracies in the percentage values in the translation reports. I spot tested several simulations in the Kikuyu and Shona locales, and the information was accurate. |
@jbphet we are having new instances of % completion status issue. Please take a look. |
@kathy-phet has let me know that fixing this isn't a priority at the moment. I'll leave it open and will check during planning meetings in the future, but as of now it is unlikely to get much of my attention anytime soon. |
Understood. We will just let the translators know to ignore the value for now. |
@solaolateju sent me a Slack message this morning where he said that translators are saying that they are seeing incorrect values for the percentage of strings that are translated. The translators are saying that the utility is reporting less than 100% when all of the strings have been translated.
As an example, he Kikuyu translator (locale =
ki
) says he/she is seeing this in greenhouse-effect, build-a-molecule, and acid-base-solutions.The text was updated successfully, but these errors were encountered: