Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for legacy visible key #411

Open
liammulh opened this issue May 27, 2023 · 0 comments
Open

Remove support for legacy visible key #411

liammulh opened this issue May 27, 2023 · 0 comments

Comments

@liammulh
Copy link
Member

There are sim string keys that have a legacy visible key. For example, see:

https://github.com/phetsims/forces-and-motion-basics/blob/cf9242a8863dfecd8eec669b5dd3bcca4bb77b5f/forces-and-motion-basics-strings_en.json#L75-L78

For more context on this issue, see phetsims/forces-and-motion-basics#298.

Once we are sure all of these legacy visible keys have been removed, we can remove the support for them in Rosetta, which will slightly reduce the complexity of our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant