Skip to content

Commit

Permalink
Removed JSHint, see phetsims/sherpa#63
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Feb 6, 2016
1 parent 838086b commit 6b2fddc
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 12 deletions.
2 changes: 0 additions & 2 deletions js/accessibility/AccessiblePeer.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ define( function( require ) {
// Creation will initialize the peer to an initial state.
Poolable.mixin( selfDrawableType, {
defaultFactory: function() {
/* jshint -W055 */
return new selfDrawableType();
},
constructorDuplicateFactory: function( pool ) {
Expand All @@ -94,7 +93,6 @@ define( function( require ) {
return pool.pop().initialize( accessibleInstance );
}
else {
/* jshint -W055 */
return new selfDrawableType( accessibleInstance );
}
};
Expand Down
3 changes: 1 addition & 2 deletions js/display/CanvasSelfDrawable.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ define( function( require ) {

// methods for forwarding dirty messages
function canvasSelfDirty() {
// we pass this method and it is only called with blah.call( ... ), where the 'this' reference is set. ignore jshint
/* jshint -W040 */
// we pass this method and it is only called with blah.call( ... ), where the 'this' reference is set.
this.markDirty();
}

Expand Down
3 changes: 1 addition & 2 deletions js/display/Instance.js
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ define( function( require ) {
sceneryLog && sceneryLog.ChangeInterval && sceneryLog.pop();
}

/* jshint -W018 */ // it's really the easiest way to compare if two things (casted to booleans) are the same?
// it's really the easiest way to compare if two things (casted to booleans) are the same?
assert && assert( !!firstChangeInterval === !!currentChangeInterval,
'Presence of first and current change intervals should be equal' );

Expand Down Expand Up @@ -841,7 +841,6 @@ define( function( require ) {
'We should have precisely one of these flags set for us to have a groupRenderer' );

// if we switched to/away from a group, our group type changed, or our group renderer changed
/* jshint -W018 */
var groupChanged = ( !!groupRenderer !== !!this.groupDrawable ) ||
( !wasStateless && this.groupChanged ) ||
( this.groupDrawable && this.groupDrawable.renderer !== groupRenderer );
Expand Down
2 changes: 0 additions & 2 deletions js/display/SelfDrawable.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ define( function( require ) {
// for pooling, allow <SelfDrawableType>.createFromPool( renderer, instance ) and drawable.freeToPool(). Creation will initialize the drawable to an initial state
Poolable.mixin( selfDrawableType, {
defaultFactory: function() {
/* jshint -W055 */
return new selfDrawableType();
},
constructorDuplicateFactory: function( pool ) {
Expand All @@ -76,7 +75,6 @@ define( function( require ) {
return pool.pop().initialize( renderer, instance );
}
else {
/* jshint -W055 */
return new selfDrawableType( renderer, instance );
}
};
Expand Down
4 changes: 0 additions & 4 deletions js/nodes/Paintable.js
Original file line number Diff line number Diff line change
Expand Up @@ -782,14 +782,12 @@ define( function( require ) {

// Paintable's version of invalidateFill()
function invalidateFill() {
/*jshint -W040 */
this.invalidateSupportedRenderers();

var stateLen = this._drawables.length;
for ( var i = 0; i < stateLen; i++ ) {
this._drawables[ i ].markDirtyFill();
}
/*jshint +W040 */
}

// Patch in a sub-type call if it already exists on the prototype
Expand All @@ -806,14 +804,12 @@ define( function( require ) {

// Paintable's version of invalidateStroke()
function invalidateStroke() {
/*jshint -W040 */
this.invalidateSupportedRenderers();

var stateLen = this._drawables.length;
for ( var i = 0; i < stateLen; i++ ) {
this._drawables[ i ].markDirtyStroke();
}
/*jshint +W040 */
}

if ( proto.invalidateStroke ) {
Expand Down

0 comments on commit 6b2fddc

Please sign in to comment.