-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential issue with stepTimer in UtteranceQueueTests #51
Comments
From #50 |
I changed these to emit the elapsed time since the list time stepTimer has emitted and so far tests have not failed for me like they did before. This is noticeably more consistent for me on Firefox where I saw elapsed time swing from 16-48 ms in between each call of the @zepumph just want to make sure you are OK with this change? |
Looks really, really great. Good bug fix. Thanks! |
The stepTimer emits in before() like
No matter how much time actually passes in the interval, we emit that
timeInterval
time as elapsed. I think this may be causing inconsistent test results. Usually when I run the tests as they are on master they pass, but every once in a while some fail.The text was updated successfully, but these errors were encountered: