Possible fix for heroku deployment #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylanb-dev
force-pushed
the
master
branch
3 times, most recently
from
f10cfe3
to
c9b9c92
Compare
|
Yeah, master is currently working towards release v0.4.0 which is still a WIP. One of the things left to do is to make sure the Heroku button still works. I believe the latest issue is around not installing node devDependencies, which currently are required to build the app. I don't think a Procfile is necessary for a Heroku button deploy, should be as simple as setting configuration in the |
|
Didn't mean to close this, I have made the modification to app.json. |
|
sweet, thanks! has this been tested in a sample deploy? |
|
Yes, pressing the deploy button on my fork deployed with no errors. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a couple of changes to make the app deployable on heroku as it gave an error before.
I'm very novice with webpack and with the process.env.PRODUCTION variable so my solution is probably incorrect.