Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung brightness issue: Better detection method? #18

Open
phhusson opened this issue Apr 9, 2018 · 4 comments
Open

Samsung brightness issue: Better detection method? #18

phhusson opened this issue Apr 9, 2018 · 4 comments

Comments

@phhusson
Copy link
Owner

phhusson commented Apr 9, 2018

At the moment the "samsung high brightness" thingy is detected based on product name (starlte/star2lte)
It is likely other devices will need this as well
We need a better way to detect it.

@phhusson
Copy link
Owner Author

phhusson commented Oct 2, 2018

Note 9 made this a lot messier. It seems like some ROMs have the issue, some don't...?

@phhusson
Copy link
Owner Author

It didn't get any better, this is still quite horrific...
A property has been added to trigger the samsung behaviour though, for easier debugging:
persist.sys.phh.samsung_backlight

@Avrution
Copy link

Is high brightness only referring to the max level, or just being higher than the "default"?

Wondering if the lack of a product name might be related to my low brightness issue on the Tab S4?

@phhusson
Copy link
Owner Author

phhusson commented Oct 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants