Add overlay for Xiaomi Redmi Note 10 #605
Conversation
Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
causes screen flashes while switching between landscape & portrait Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
|
#535 might help since it is essentially the same device. The SystemUI definitely needs overlaying. Manually setting the rounded corners fixes truncation but the status bar height needs to be set for the notch to work correctly. |
|
@azan-n I've tested all the scenarios of portrait & landcapes & did not found a single notch issue. You can literally take example of RN11 where he didn't even include any dimensional values.
That's the reason I atleast included rounded corner dimens.
I don't think so. System UI attributes aren't really necessary as they're just purely aesthetic paddings & give no extra functionality. There aren't any issues whatsoever with the existing strings tbh. |
|
what's the status here? is this pr mergeable? |
Yes go ahead |
reverts mistakenly modified RN10P strings by me Signed-off-by: Prince Cooper <8982359-pc00per@users.noreply.gitlab.com>
Tested