Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bootstrap 3: Pagination structure change #373

Closed
wants to merge 1 commit into from

4 participants

@mykehsd

Bootstrap 2 had the structure:
<div class="pagination">
<ul>
....

Bootstrap 3 has the structure:
<ul class="pagination">
....
`

@phiamo
Owner

mhh we could use a constant or config value somehow to determine which pagination structure to use, or we could use composerbridge to as composer somehow what to use. But this should be havily cached and then written into some conf value during composer update e.g.
this value could be used during compilation to load an form-v3.html.twig which extends the form.html.twig and loads it instead ...

@WedgeSama

There are to many changes in bootstrap 3, so we need to make a lot of changes to this bundle. I agree with @phiamo . Maybe need an update with the possibility to specify in config file v2 or v3 and load good files. And it will keep the compatibility with v2 and not only update to v3.

@phiamo
Owner

i will try to integrate this together with #508 this weekend

@phiamo
Owner

Merged into wip-bootstrap-3-integration

@phiamo phiamo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 23, 2013
  1. @mykehsd
This page is out of date. Refresh to see the latest.
Showing with 34 additions and 36 deletions.
  1. +34 −36 Resources/views/Pagination/sliding.html.twig
View
70 Resources/views/Pagination/sliding.html.twig
@@ -1,43 +1,41 @@
{% if pageCount > 1 %}
- <div class="pagination">
- {% set item = 'MopaBootstrapBundle:Pagination:sliding_item.html.twig' %}
+ {% set item = 'MopaBootstrapBundle:Pagination:sliding_item.html.twig' %}
- <ul>
- {% include item with {name: 'first',
- text: '«',
- page: first is defined ? first : null,
- clickable: first is defined and current != first
- }
- %}
+ <ul class="pagination">
+ {% include item with {name: 'first',
+ text: '«',
+ page: first is defined ? first : null,
+ clickable: first is defined and current != first
+ }
+ %}
- {% include item with {name: 'prev',
- text: '' ~ 'Previous' | trans({}, 'pagination'),
- page: previous is defined ? previous : null,
- clickable: previous is defined
- }
- %}
+ {% include item with {name: 'prev',
+ text: '' ~ 'Previous' | trans({}, 'pagination'),
+ page: previous is defined ? previous : null,
+ clickable: previous is defined
+ }
+ %}
- {% for page in pagesInRange %}
- {% include item %}
- {% endfor %}
+ {% for page in pagesInRange %}
+ {% include item %}
+ {% endfor %}
- {%
- include item with {
- name: 'next',
- text: 'Next' | trans({}, 'pagination') ~ '',
- page: next is defined ? next : null,
- clickable: next is defined
- }
- %}
+ {%
+ include item with {
+ name: 'next',
+ text: 'Next' | trans({}, 'pagination') ~ '',
+ page: next is defined ? next : null,
+ clickable: next is defined
+ }
+ %}
- {%
- include item with {
- name: 'last',
- text: '»',
- page: last is defined ? last : null,
- clickable: last is defined and current != last
- }
- %}
- </ul>
- </div>
+ {%
+ include item with {
+ name: 'last',
+ text: '»',
+ page: last is defined ? last : null,
+ clickable: last is defined and current != last
+ }
+ %}
+ </ul>
{% endif %}
Something went wrong with that request. Please try again.