Bootstrap 3: Pagination structure change #373

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@mykehsd
mykehsd commented Jan 23, 2013

Bootstrap 2 had the structure:
`

    ....`

    Bootstrap 3 has the structure:
    `


      ....``

@phiamo
Owner
phiamo commented Jul 25, 2013

mhh we could use a constant or config value somehow to determine which pagination structure to use, or we could use composerbridge to as composer somehow what to use. But this should be havily cached and then written into some conf value during composer update e.g.
this value could be used during compilation to load an form-v3.html.twig which extends the form.html.twig and loads it instead ...

@WedgeSama

There are to many changes in bootstrap 3, so we need to make a lot of changes to this bundle. I agree with @phiamo . Maybe need an update with the possibility to specify in config file v2 or v3 and load good files. And it will keep the compatibility with v2 and not only update to v3.

@Sharom
Sharom commented Jul 31, 2013

@WedgeSama 👍

@phiamo
Owner
phiamo commented Aug 9, 2013

i will try to integrate this together with #508 this weekend

@phiamo
Owner
phiamo commented Aug 10, 2013

Merged into wip-bootstrap-3-integration

@phiamo phiamo closed this Aug 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment