Interface Builder Designable #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 3, 2016 23:12
…ange. Updated code related to activePointsInterval that did otherwise. This was mainly to fix startAnimations which were iterating from startIndex to endIndex and thus iterating once even on empty range 0..<0. Also, since activePointsInterval.endIndex can’t be bigger than data.count we can simplify some checks.
For enums additional Int properties were created to allow setting them in IB.
Now all of the public properties are available except for fonts and closures.
Effectively the fix was just disabling rightToLeft while in IB because it seems that IB does not really work well with nonzero UIScrollView content offsets.
|
This is great! I really appreciate the help. I will test the changes and then merge it in for everyone to use today. |
|
You may want to pay a closer attention to the first commit since changes there impact also the behaviour when running on real target (i.e. not only TARGET_INTERFACE_BUILDER). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the necessary changes so that we could fine-tune looks of ScrollableGraphView right from Interface Builder as requested here: #8
Making it IB compatible mainly meant disabling animations (displayLink) while in IB and making sure the height is big enough so that we don't hit assert (layer.zeroYPosition > 0).