Various front end updates #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out set to "always" is a pain, for example if we write:
import { createRoot } from "react-dom/client"
import/extensions doesn't like this. So if you add the explicit
file extension:
import { createRoot } from "react-dom/client.js"
That makes ESLint happy, but tsc now fails because it can't find
the types definition for it, because @types/react-dom only
has "exports" defined for "/client" not "/client.js".
So it seems its impossible to enforce extensions on package imports
while at the same time using tsc.
This is automatically enabled when using breeze:install to instead React with Intertia, I don't really see any downside in enabling it. See: laravel/framework#44096
So that components.json and eslint-import-resolver-typescript work as they don't appear to support "tsc -b".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for details.