Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various front end updates #32

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Various front end updates #32

merged 3 commits into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. ESLint: Change import/extensions from "always" to "ignorePackages"

    It turns out set to "always" is a pain, for example if we write:
    
        import { createRoot } from "react-dom/client"
    
    import/extensions doesn't like this. So if you add the explicit
    file extension:
    
        import { createRoot } from "react-dom/client.js"
    
    That makes ESLint happy, but tsc now fails because it can't find
    the types definition for it, because @types/react-dom only
    has "exports" defined for "/client" not "/client.js".
    
    So it seems its impossible to enforce extensions on package imports
    while at the same time using tsc.
    philbates35 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3544ff3 View commit details
    Browse the repository at this point in the history
  2. Kernel: Enable AddLinkHeadersForPreloadedAssets middleware

    This is automatically enabled when using breeze:install to instead
    React with Intertia, I don't really see any downside in enabling
    it.
    
    See: laravel/framework#44096
    philbates35 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5c73e4d View commit details
    Browse the repository at this point in the history
  3. TS: Move paths from tsconfig.app.json to tsconfig.json

    So that components.json and eslint-import-resolver-typescript
    work as they don't appear to support "tsc -b".
    philbates35 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    02e0c51 View commit details
    Browse the repository at this point in the history