Skip to content

Commit

Permalink
Move Scroller.init() up the handler stack.
Browse files Browse the repository at this point in the history
Move scroller initialisation so that its key handlers are above insert
mode in the handler stack.  This ensures that the scroller sees keyup
events if we enter insert mode while continuous scrolling.

Fixes #1526.
  • Loading branch information
smblott-github committed Mar 11, 2015
1 parent 2db6971 commit 0514b06
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions content_scripts/vimium_frontend.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,14 @@ window.initializeModes = ->
keypress: (event) => onKeypress.call @, event
keyup: (event) => onKeyup.call @, event

Scroller.init settings

# Install the permanent modes. The permanently-installed insert mode tracks focus/blur events, and
# activates/deactivates itself accordingly.
new BadgeMode
new NormalMode
new PassKeysMode
new InsertMode permanent: true
new GrabBackFocus
Scroller.init settings

#
# Complete initialization work that sould be done prior to DOMReady.
Expand Down

0 comments on commit 0514b06

Please sign in to comment.