Skip to content

Commit

Permalink
Note that createTab/pages/blank.html doesn't work in incognito mode.
Browse files Browse the repository at this point in the history
  • Loading branch information
smblott-github committed Mar 15, 2015
1 parent 3c175e2 commit 359c6c3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions background_scripts/main.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,8 @@ moveTab = (callback, direction) ->
BackgroundCommands =
createTab: (callback) ->
url = Settings.get "newTabUrl"
# FIXME(smblott). "pages/blank.html" doesn't work in incognito mode. It opens the tab in a
# non-incognito-mode window. Perhaps we should just use "chrome://newtab" in that case?
url = chrome.runtime.getURL url if url == "pages/blank.html"
openUrlInNewTab { url }, callback
duplicateTab: (callback) ->
Expand Down

0 comments on commit 359c6c3

Please sign in to comment.