[Bug] using F opens links twice on Firefox Nightly #3964

s-marios · 2021-11-30T02:34:29Z

Hi,

When I'm using shift + f to open a link in a new tab, instead of one tab two tabs with the same content appear.

I'm using Firefox Nightly and this started happening 1-2 days ago. Here's at least one more user experiencing the same problem #3579 (comment) .

Anybody else affected?

gdh1995 · 2021-12-03T13:05:32Z

I also noticed this days ago.

Artturin · 2021-12-04T02:46:14Z

im on nightly too

Artturin · 2021-12-07T04:15:38Z

https://github.com/gdh1995/vimium-c does not have this problem though a weird thing is that when i disable vimium-ff and then install vimium-c, the vimium-c will have the same problem but it is fixed after i restart firefox

(only tested once so may not be reproducible)

gdh1995 · 2021-12-07T04:22:31Z

@Artturin Vimium C uses a trick which is not safe on a loaded page, so it only enables this trick if it runs when a page begins loading. If you want to test Vimium C again, please refresh tabs after you enable it and before tests.

evenlee · 2021-12-08T13:08:58Z

I am using firefox 96.0b2 dev edition, have same problem

JoshMock · 2021-12-09T15:29:49Z

Also experiencing this on 96.0b2 developer edition.

sandeshghanta · 2021-12-13T19:10:47Z

Also experiencing this issue in Firefox developer edition 96.0b4 version.

pngdeity · 2021-12-16T19:49:14Z

Experiencing the issue on Firefox Nightly 97.0a1

rvighne · 2022-01-08T21:56:50Z

This has also been happening in beta for a long time. Is a fix possible / planned as of now? FF 96 will hit the release channel very soon on 1/11 which will affect a lot more users.

QHayward · 2022-01-11T16:53:08Z

I installed Firefox today on a new computer, and can confirm that I am having this issue

keepiru · 2022-01-11T22:57:01Z

I'm experiencing this after upgrading to FF 96.0 today.

mcauley-penney · 2022-01-12T16:41:20Z

Just upgraded to 96.0 and also experiencing

ashuradji · 2022-01-12T23:57:44Z

Same error here, i just updated to FF 96. Only happens in Firefox

philc · 2022-01-13T00:33:33Z

I haven't looked at this, but it's clearly important and manifesting for many users. PRs welcome!

…

On Wed, Jan 12, 2022 at 3:57 PM, Omar Monrroy < ***@***.*** > wrote: Same error here, i just updated to FF 96. Only happens in Firefox — Reply to this email directly, view it on GitHub ( #3964 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAACDFQ4UAEHHTHHKQZYS43UVYIQLANCNFSM5JAUFTSQ ). Triage notifications on the go with GitHub Mobile for iOS ( https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 ) or Android ( https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub ). You are receiving this because you are subscribed to this thread. Message ID: <philc/vimium/issues/3964/1011558962 @ github. com>

It seems Firefox 96 allows extensions to trigger native click behaviors. See philc#3964 for reports. Although this is not listed in https://www.mozilla.org/en-US/firefox/96.0/releasenotes/, I think it's safe enough to skip preventing since Firefox 96.

gdh1995 · 2022-01-13T13:46:45Z

@philc I've filed #3985 . And I think #3867 is also worth merging.

R2robot · 2022-01-15T18:45:57Z

Happening on the general public releases now. 96.0.1

It seems Firefox 96 allows extensions to trigger native click behaviors. See philc#3964 for reports. Although this is not listed in https://www.mozilla.org/en-US/firefox/96.0/releasenotes/, I think it's safe enough to skip preventing since Firefox 96. (cherry picked from commit cf420fb)

It seems Firefox 96 allows extensions to trigger native click behaviors. See philc#3964 for reports. Although this is not listed in https://www.mozilla.org/en-US/firefox/96.0/releasenotes/, I think it's safe enough to skip preventing since Firefox 96.

cupcakearmy · 2022-01-18T10:14:41Z

Same issue here on 96.0.1

snprajwal · 2022-01-18T17:31:19Z

Same issue here on 96.0.1

sarrietav-dev · 2022-01-19T19:42:38Z

Same issue here on 96.0.1. I hope this gets fixed soon.

freefal · 2022-01-19T22:40:54Z

Also seeing this issue.

It seems Firefox 96 allows extensions to trigger native click behaviors. See #3964 for reports. Although this is not listed in https://www.mozilla.org/en-US/firefox/96.0/releasenotes/, I think it's safe enough to skip preventing since Firefox 96.

philc · 2022-01-20T04:38:20Z

Thanks everyone for your patience. I've merged #3985 and will release to the extension stores later tonight.

WillDHB · 2022-01-21T17:25:34Z

It looks like the Vimium extension has been updated, but I don't see anything for Vimium-FF...what is the difference between the two? It looks like they're both yours.

Artturin · 2022-01-21T18:11:18Z

@philc i think you pushed the update with a wrong extension name
https://addons.mozilla.org/en-US/firefox/addon/vimium/ was created yesterday

https://addons.mozilla.org/en-US/firefox/addon/vimium-ff/ is the original extension

philc · 2022-01-21T22:28:03Z

Ugh! Sorry folks. Yeesh. I’ll look at this tonight.

…

On Fri, Jan 21, 2022 at 10:11 AM Artturi ***@***.***> wrote: @philc <https://github.com/philc> i think you pushed the update to a wrong extension name https://addons.mozilla.org/en-US/firefox/addon/vimium/ was created yesterday https://addons.mozilla.org/en-US/firefox/addon/vimium-ff/ is the original extension — Reply to this email directly, view it on GitHub <#3964 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACDFXLVSW2LKVYCVLNXALUXGOVFANCNFSM5JAUFTSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

philc · 2022-01-22T05:40:13Z

I've updated vimium-ff ( https://addons.mozilla.org/en-US/firefox/addon/vimium-ff/ ) with the latest version — v1.67.1 — and put a notice on the vimium ( https://addons.mozilla.org/en-US/firefox/addon/vimium/ ) page to visit vimium-ff. For historical context, at the time we published this extension for Firefox, "vimium" as a name wasn't available, but now it seems it is. I accidentally discovered this as part of the uploading process. However, vimium-ff has the critical mass of users, so we'll keep using that.

…

On Fri, Jan 21, 2022 at 2:27 PM, Phil Crosby < ***@***.*** > wrote: Ugh! Sorry folks. Yeesh. I’ll look at this tonight. On Fri, Jan 21, 2022 at 10:11 AM Artturi < notifications@ github. com ( ***@***.*** ) > wrote: > > > > > > > @ philc ( https://github.com/philc ) i think you pushed the update to a > wrong extension name > https:/ / addons. mozilla. org/ en-US/ firefox/ addon/ vimium/ ( > https://addons.mozilla.org/en-US/firefox/addon/vimium/ ) was created > yesterday > > > > https:/ / addons. mozilla. org/ en-US/ firefox/ addon/ vimium-ff/ ( > https://addons.mozilla.org/en-US/firefox/addon/vimium-ff/ ) is the original > extension > > > > — > Reply to this email directly, view it on GitHub ( > #3964 (comment) ) , or > unsubscribe ( > https://github.com/notifications/unsubscribe-auth/AAACDFXLVSW2LKVYCVLNXALUXGOVFANCNFSM5JAUFTSQ > ). > Triage notifications on the go with GitHub Mobile for iOS ( > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > ) or Android ( > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub > ). > You are receiving this because you were mentioned. Message ID: <philc/vimium/issues/3964/1018745478 > @ github. com> > >

SafwanLjd · 2022-01-22T06:20:46Z

@philc I still have this issue even after updating to v1.67.1 the same goes for https://addons.mozilla.org/en-US/firefox/addon/vimium/

xstnztk · 2022-01-22T07:24:32Z

The update to v1.67.1 fixes the double-open issue for me but seems to have swapped the functionality of LinkHints.activateModeToOpenInNewTab and LinkHints.activateModeToOpenInNewForegroundTab, i.e. LinkHints.activateModeToOpenInNewForegroundTab now opens the tab in a new background tab and activateModeToOpenInNewTab opens it in a new foreground tab.

I restarted Firefox to make sure this was not a transient problem but it persists. TBH I do not see anything in the code modification which could cause this but I am not really a web extension developer.

AFAICT this seems to be caused by setting "When you open a link, image or media in a new tab, switch to it immediately" in the Firefox options, i.e. when this option is activated, the two Vimium functions are swapped. They only work as expected if the Firefox option is not active. OTOH I have this option set since ages and only experienced the incorrect Vimium behavior since the extension update.

For the time being I can work around the problem by simply using the "wrong" Vimium command. Should I file a new issue for this?

gdh1995 · 2022-01-22T08:09:39Z

I have this option set since ages and only experienced the incorrect Vimium behavior since the extension update.

@xstnztk It's because old versions of Vimium "simulates" OpenInNewTab and so on, so it didn't trigger the Firefox's built-in process which considers about the option.

This is a new issue: do we need a new command option for LinkHints.* to swap the ctrl and ctrl+shift sent by Vimium?

see philc/vimium#3964

for philc/vimium#3964 (comment)

s-marios · 2022-01-24T05:42:03Z

Hi,
indeed, 1.67.1 fixes the double open problem! Thank you for that.

As such I'm closing this bug as fixed. Cheers!
[edit: I hadn't had my cup of coffee, topic was already closed]

see philc/vimium#3964

for philc/vimium#3964 (comment)

decadent · 2022-01-26T18:49:55Z

Coincidentally, this perturbance might've fixed a long-standing annoyance that new tabs were always opened by Vimium right after the currently active one—instead of one after another rightwards (and FF didn't provide APIs to open them in a proper order).

Unless some other change was made to that end.

freefal · 2022-01-26T18:54:36Z

Agreed. This was always a minor annoyance for me as well. Now fixed.

ashuradji · 2022-01-27T06:53:52Z

Excuse me, this issue it's fixed in FF Developer Edition but still happens in Firefox to me

gdh1995 · 2022-01-27T08:12:24Z

@drk01 Sorry but what's the versions of your 2 Firefox and their Vimium?

ashuradji · 2022-01-27T14:01:52Z

@gdh1995 FF 96.0.2 & FF Developer 97.0b3.
Vimium 1.67.1 in both browsers

C4K3 · 2022-01-28T17:26:07Z

Same here, still happening to me on 1.67.1. However if I install the extension in a fresh profile, then it doesn't happen on that profile. Will try to figure out what setting / extension is causing it.

C4K3 · 2022-01-29T18:09:21Z

It's privacy.resistFingerprinting, if I enable that then the two-tabs behavior occurs.

gdh1995 · 2022-01-30T02:02:05Z

Well, it's a same bug caused by fake navigator.userAgent - see #3989 (comment) . I'll file a new PR now.

gdh1995 mentioned this issue Dec 29, 2021

follow new tab opens 2 tabs #3979

Closed

gdh1995 mentioned this issue Jan 13, 2022

not prevent click events since Firefox 96 #3985

Merged

gdh1995 mentioned this issue Jan 15, 2022

LinkHints.activateModeToOpenInNewForegroundTab opening tabs twice #3986

Closed

philc closed this as completed in #3985 Jan 20, 2022

philc mentioned this issue Jan 22, 2022

Firefox open link in new tab opens two duplicate tabs #3989

Closed

gdh1995 added a commit to gdh1995/vimium-c that referenced this issue Jan 22, 2022

not hook click events since Firefox 96

9758153

see philc/vimium#3964

gdh1995 added a commit to gdh1995/vimium-c that referenced this issue Jan 22, 2022

LinkHints: add activeOnCtrl to swap Ctrl and Ctrl+Shift

a40f91b

for philc/vimium#3964 (comment)

xstnztk mentioned this issue Jan 22, 2022

Firefox option swaps foreground / background tab commands #3991

Open

gdh1995 added a commit to gdh1995/vimium-c that referenced this issue Jan 24, 2022

not hook click events since Firefox 96

bac8759

see philc/vimium#3964

gdh1995 added a commit to gdh1995/vimium-c that referenced this issue Jan 24, 2022

LinkHints: add activeOnCtrl to swap Ctrl and Ctrl+Shift

777588e

for philc/vimium#3964 (comment)

gdh1995 mentioned this issue Jan 30, 2022

fix opening links twice when privacy.resistFingerprinting is enabled or on Firefox 91.6+ #4000

Merged

mesbahamin mentioned this issue Jan 1, 2023

Shift+F Opens two Tabs Instead of One #4194

Closed

[Bug] using F opens links twice on Firefox Nightly #3964

[Bug] using F opens links twice on Firefox Nightly #3964

Comments

s-marios commented Nov 30, 2021

gdh1995 commented Dec 3, 2021

Artturin commented Dec 4, 2021

Artturin commented Dec 7, 2021 • edited Loading

gdh1995 commented Dec 7, 2021

evenlee commented Dec 8, 2021

JoshMock commented Dec 9, 2021

sandeshghanta commented Dec 13, 2021

pngdeity commented Dec 16, 2021

rvighne commented Jan 8, 2022

QHayward commented Jan 11, 2022

keepiru commented Jan 11, 2022

mcauley-penney commented Jan 12, 2022

ashuradji commented Jan 12, 2022

philc commented Jan 13, 2022 via email

gdh1995 commented Jan 13, 2022

R2robot commented Jan 15, 2022

cupcakearmy commented Jan 18, 2022

snprajwal commented Jan 18, 2022

sarrietav-dev commented Jan 19, 2022

freefal commented Jan 19, 2022

philc commented Jan 20, 2022

WillDHB commented Jan 21, 2022

Artturin commented Jan 21, 2022 • edited Loading

philc commented Jan 21, 2022 via email

philc commented Jan 22, 2022 via email

SafwanLjd commented Jan 22, 2022

xstnztk commented Jan 22, 2022

gdh1995 commented Jan 22, 2022

s-marios commented Jan 24, 2022 • edited Loading

decadent commented Jan 26, 2022 • edited Loading

freefal commented Jan 26, 2022

ashuradji commented Jan 27, 2022

gdh1995 commented Jan 27, 2022

ashuradji commented Jan 27, 2022 • edited Loading

C4K3 commented Jan 28, 2022

C4K3 commented Jan 29, 2022

gdh1995 commented Jan 30, 2022

Artturin commented Dec 7, 2021 •

edited

Loading

Artturin commented Jan 21, 2022 •

edited

Loading

s-marios commented Jan 24, 2022 •

edited

Loading

decadent commented Jan 26, 2022 •

edited

Loading

ashuradji commented Jan 27, 2022 •

edited

Loading