Support all mappable keys in passkeys and treat exit insert mode as a command #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works fantastic, even |
Add exitInsertMode, allow binding single keys only
mrmr1993
force-pushed
the
complex-passkeys+exit-insert-mode
branch
from
a9babf5
to
b12c024
Compare
|
Stale since modes landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines #1140 and #1368, and adds a tweak to support passkeys for
exitInsertMode. It does the majority of what is outlined in this comment with a view to making #1211 mergable and enabled by default.Specifically, this PR:
exitInsertModeandexitInsertModeAndPassKeycommands (via Add exitInsertMode, allow binding single keys only #1140), which fixes Allow any key to mapped to "exit mode" instead of just <esc> #301 and starts work on resolving Pressing 'esc' no longer closes Facebook message windows #1176.exitInsertMode/exitInsertModeAndPassKeycommands.