-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use package.json to manage dependecies. #3029
Conversation
Thanks, @ris58h. I get this error...
(The complete error log is 3000 lines, so I'll not post it here.) I tried with a fresh clone too. Same thing. npm version is 6.0.1. Separately, this is going to use the global |
@smblott-github It's strange. Everything works fine on my machine and travis seems ok too. Could you provide the log? |
Here's the log. |
@smblott-github I believe that problem is related to node. As I can see in the log you have node v6.12.2. I use v9.6.1. Vimium's travis file contains node_js 8. |
That's it, thanks. And...
It seems that npm does indeed arrange that Could you...
Note -- something good about this... Legacy users with existing clones are unaffected, I think, right? |
I do not have coffeescript uninstalled globally so it uses coffeescript/cake from local node_modules. I do not change any js-code so it won't affect the legacy users, I believe. I would like to see your opinion about the points I described in the first message: Code Coverage and shoulda.js. |
You really, really do not want to go there! More seriously, that's a separate matter; so not for this PR. The test framework is really showing its age, but re-working it would probably be a very large job for little pay back.
I have no opinion on this. |
I know. It's related to dependencies so I've just asked.
OK. I would investigate that later. One more question: I see that |
I don't use it (because sometimes I want to commit code with the tests broken). |
According to npm docs only two fields are required: name & version. I would like to keep things simple and don't add unnecessary fields because Vimium is not going to be published in the npm registry anyway.
I've done more research about that problem and it seems like it's just an npm-related issue (fixed). |
@smblott-github Any feedback? |
I'll get to this soon. |
Related: #3226. Thanks @ris58h. I may incorporate some of this work as part of converting coffeescript to es6. |
|
CoffeeScript is a dependency now and there shouldn't be such issues as in #3023
But there are some things to add:
It would simplify build if we could get rid of shoulda.js and that git submodule and use any other test runner library/framework.
I couldn't run Code Coverage Is Code Coverage broken? #3028 so this part remains unchanged. It would be nice to move jscoverage and temp to devDependencies too.