Fixed Reddit scrolling #3327
Merged
Fixed Reddit scrolling #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddit.com and new.reddit.com had special scrolling properties, but not www.reddit.com. This fix should allow users to scroll properly on reddit's redesign on all addresses.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vimium handles scrolling on reddit's redesign by applying special properties to the site. These properties have been applied to reddit.com and new.reddit.com, but not www.reddit.com. I added this to the special list.
I didn't run the technical tests mentioned in CONTRIBUTING.md because my computer doesn't know what npm is, but I figured it wasn't necessary for such a small fix.
I did change the relevant .json file in the source installed on my computer, and tested scrolling, It worked perfectly.
This should solve Issue #3119 and Issue #3295 (and possibly other duplicate issues).
Thanks for your consideration.