Look at title and aria-label attributes for next/prev link discovery #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sersorrel
force-pushed
the
next-prev-matching-attributes
branch
from
e72aa3d
to
cd1b40c
Compare
|
Is this on track to be merged? |
philc
added a commit
that referenced
this pull request
Sep 17, 2023
|
Seems reasonable to me. I added this PR in 805e552. Thanks @sersorrel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes Vimium also use the contents of
titleandaria-labelattributes, if present, to discover potential links to the next/previous page. This is useful for pages like this Adafruit guide, which uses a Font Awesome icon (<i class="fa fa-chevron-right">) to create the arrow on the next page button but also marks up that button witharia-label="Next page".Tests are included.
Fixes #3739.