Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon maintenance #4511

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Icon maintenance #4511

merged 3 commits into from
Jul 16, 2024

Conversation

leoheitmannruiz
Copy link
Contributor

@leoheitmannruiz leoheitmannruiz commented Jun 30, 2024

  1. Remove three unused icons

  2. Update the icon to https://github.com/vimium/vimium.github.com/blob/master/vimium_logo.svg

inkscape -w 16  -h 16  icon.svg -o icon16.png
inkscape -w 48  -h 48  icon.svg -o icon48.png
inkscape -w 128 -h 128 icon.svg -o icon128.png
inkscape -w 295 -h 295 icon.svg -o vimium.png

zopflipng -y icon16.png  icon16.png
zopflipng -y icon48.png  icon48.png
zopflipng -y icon128.png icon128.png
zopflipng -y vimium.png  vimium.png

Is vimium.png needed? Or can it be deleted and icon128.png used instead? Why is it 295px?
It's only used here:

./background_scripts/main.js:761:      iconUrl: chrome.runtime.getURL("icons/vimium.png"),
  1. And a tid bit in make.js, so that Firefox uses the SVG directly.

@philc
Copy link
Owner

philc commented Jul 16, 2024

Looks good, thank you @leoheitmannruiz. I'll test it soon and then merge. I'll look into what vimium.png is used for.

@philc philc merged commit 9801fa9 into philc:master Jul 16, 2024
@philc
Copy link
Owner

philc commented Jul 16, 2024

I looked into vimium.png. It might've been used as a high-res icon for the chrome store at some point, but today, the store icon asset is supposed to be 128x128, so icon128.png can work for that, and for the notification use case. I've removed it in 7ff8cb6.

@leoheitmannruiz
Copy link
Contributor Author

Great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants