Final icon maintenance #4524
Merged
Final icon maintenance #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be good now hehe Oh, and, I changed the default icon to action_disabled, as currently the action_enabled icon is shown on pages like about:newtab or about:preferences. Now, when Vimium isn't allowed to run, action_disabled is displayed. If Vimium is allowed to run, the proper icon is shown. Seems a lot better to me this way. Not sure if I'm missing something silly :) |
|
The icons are looking good. Thanks @leoheitmannruiz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I'd finish #4511 off with updating the action icons :)
The V is the same as in https://github.com/philc/vimium/blob/master/icons/icon.svg. The blue is #3680f0, that is, the color in the middle of the Chromium logo. I found it a little strong at first, though started to enjoy it super quickly. Hope you like it! Though, of course, feel free to complain and I'll see what I can do :)
PS: I'm quite happy about how well the XML turned out hihi