Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What look like two very small bugs ... #707

Merged
merged 2 commits into from
Nov 9, 2012
Merged

What look like two very small bugs ... #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
450f0ec
Looks like missing parentheses.
smblott-github Nov 5, 2012
8b02be8
Avoid empty query terms.
smblott-github Nov 5, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion background_scripts/completion.coffee
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ class DomainCompleter
for domain in domainCandidates for domain in domainCandidates
recencyScore = RankingUtils.recencyScore(@domains[domain].lastVisitTime || 0) recencyScore = RankingUtils.recencyScore(@domains[domain].lastVisitTime || 0)
wordRelevancy = RankingUtils.wordRelevancy(queryTerms, domain, null) wordRelevancy = RankingUtils.wordRelevancy(queryTerms, domain, null)
score = wordRelevancy + Math.max(recencyScore, wordRelevancy) / 2 score = (wordRelevancy + Math.max(recencyScore, wordRelevancy)) / 2
results.push([domain, score]) results.push([domain, score])
results.sort (a, b) -> b[1] - a[1] results.sort (a, b) -> b[1] - a[1]
results results
Expand Down
3 changes: 2 additions & 1 deletion background_scripts/main.coffee
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -192,8 +192,9 @@ handleSettings = (args, port) ->


refreshCompleter = (request) -> completers[request.name].refresh() refreshCompleter = (request) -> completers[request.name].refresh()


whitespaceRegexp = /\s+/
filterCompleter = (args, port) -> filterCompleter = (args, port) ->
queryTerms = if (args.query == "") then [] else args.query.split(" ") queryTerms = if (args.query == "") then [] else args.query.split(whitespaceRegexp)
completers[args.name].filter(queryTerms, (results) -> port.postMessage({ id: args.id, results: results })) completers[args.name].filter(queryTerms, (results) -> port.postMessage({ id: args.id, results: results }))


getCurrentTimeInSeconds = -> Math.floor((new Date()).getTime() / 1000) getCurrentTimeInSeconds = -> Math.floor((new Date()).getTime() / 1000)
Expand Down