Replace all deprecated sendRequest() calls with new sendMessage() ones #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for the patch. I'll look into this later tonight and merge this in. |
|
Thanks! |
|
FWIW, building and installing @sainaen's fix has vimium working perfectly for me in the current version of Chromium. |
philc
added a commit
that referenced
this pull request
May 7, 2013
Replace all deprecated sendRequest() calls with new sendMessage() ones
|
Merged in. Great job @sainaen. |
|
Thanks! I'm glad I was able to help. |
|
@sainaen |
davidwallacejackson
pushed a commit
to davidwallacejackson/vimium
that referenced
this pull request
Apr 3, 2014
Replace all deprecated sendRequest() calls with new sendMessage() ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #820.
Tested on Google Chrome 28.0.1496.0 dev, Debian Sid x86_64.
Probably, there is something deeper in that problem — even with this patch there are some errors thrown by background script. But these changes was enough to make it work, so I stopped my investigation.