Item Timer Stop #42
Closed
Item Timer Stop #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the criteria for stopping the item time GUI. During adaptive test the person$terminated_sucessfully does not = T until the test is closed. If you use an adaptive test and reach the lastpage, the itemtimer continous to run.
philchalmers
reviewed
Nov 9, 2021
| @@ -50,7 +50,7 @@ server <- function(input, output, session) { | |||
| output$itemTime <- renderText({ | |||
| printDebug("itemTime", 3) | |||
| invalidateLater(200, session) | |||
| if(.MCE[[sessionName]]$person$terminated_sucessfully) | |||
There was a problem hiding this comment.
I think this should be changed to if(.MCE[[sessionName]]$person$terminated_sucessfully || .MCE[[sessionName]]$STOP) to avoid breaking the previous code, but also allowing for the STOP state to be checked. I'll merge it after this change is added!
There was a problem hiding this comment.
Very good idea. Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the criteria for stopping the item time GUI. During adaptive test the
person$terminated_sucessfullydoes not == T until the test is closed. If you use an adaptive test and reach thelastpage, theitemtimecontinous to run. Please let me know if i am not making any sense and you need a reproducible example of this.Also please not that this solves the problem with the
itemtime, but I am not certain that it doesnt crash something else... Does it make sense from your perspective?Sincerely
Magnus Nordmo