Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setColor in color_action.coffee #19

Closed
tester22 opened this issue Jul 12, 2015 · 5 comments
Closed

setColor in color_action.coffee #19

tester22 opened this issue Jul 12, 2015 · 5 comments

Comments

@tester22
Copy link
Contributor

Hi,

This code breaks rules for me:
https://github.com/philip1986/pimatic-led-light/blob/master/predicates_and_actions/color_action.coffee#L36

What is the purpose of this function?
@philip1986
Copy link
Owner

Hi,

the purpose is to change the color of the light device. So you could have a rule like:
"if ... than set device to red "

Can you please provide an example of the breaking rules.

@tester22
Copy link
Contributor Author

Hi.

My rule is as simple as:

set blinkstick to red

The error message is setColor: is undefined.

When removing this code the rule works as expected (changeing color to red).

13 jul 2015 kl. 10:07 skrev philip1986 notifications@github.com:

Hi,

the purpose is to change the color of the light device. So you could have a rule like:
"if ... than set device to red "

Can you please provide an example of the breaking rules.

—
Reply to this email directly or view it on GitHub.

@tester22
Copy link
Contributor Author

Another user seems to have the same issue after the last update: http://forum.pimatic.org/topic/687/problems-with-color-change-pimatic-led-light-plugin-with-milight

@philip1986
Copy link
Owner

@tester22 you are right the code at this line is broken. It will be fixed soon.

mwittig added a commit to mwittig/pimatic-led-light that referenced this issue Sep 7, 2015
@mwittig
Suggested Fix for issue philip1986#19
59c4a31
@mwittig mwittig mentioned this issue Sep 7, 2015
Merged
philip1986 pushed a commit that referenced this issue Oct 3, 2015
Merge pull request #25 from mwittig/master
9dc9e4c 
Suggested fixes for issues #18, #19, and #24
philip1986 pushed a commit that referenced this issue Oct 4, 2015
Merge branch 'master' of github.com:philip1986/pimatic-led-light into…
6bc63ab 
… development_xento

# By Philip Patzer (15) and others
# Via philip1986 (4) and Philip Patzer (3)
* 'master' of github.com:philip1986/pimatic-led-light: (21 commits)
  include libudev-dev agin as travis dependency
  remove usb dependencies for blinkstick
  dirty workaround to run tests at travis
  libusb-1.0-0-dev
  add sudo libusb-1.0-0.dev as travis dependency
  add libudev-dev as travis dependency
  add .travis.yml
  bugfixes and unskip tests due to this fixes
  unskip test and adjust test case to actual behavior
  add test script to package.json
  Increased command delay to avoid drop-outs due to packet loss
  Suggested Fix for issue #19
  revert validation changes in iwy_master.coffee
  style
  MilightRF24Port workaround for testing
  add basic tests for iwy master and milight
  Fixed update of 'mode' property value as part of setColor() method.
  Fix for issue #18. Added section 'Installation' to document dependency on libudev-dev on Raspbian and Debian systems
  Fix for issue #24. Milight setColor() raises 'color undefined' error.
  Added DummyDevice.
  ...
@philip1986
Copy link
Owner

fixed by #25

@philip1986 philip1986 mentioned this issue Oct 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tester22 @philip1986