New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested fixes for issues #18, #19, and #24 #25
Conversation
… dependency on libudev-dev on Raspbian and Debian systems
I think we reach a degree of complexity were we need tests to ensure the stability of our code. I already thought about an approach for tests like this, which takes also in account that you like to split the plugin by devices . So I will try to add some basic tests. |
https://github.com/philip1986/pimatic-led-light/pull/25/files#diff-fc25f60a59d04b30ef5515738aff8bc6R55 |
Agree on testing :) |
Yeh we need to refactor this on/off implementation, its also quite confusing I just realized it during writing the tests. |
Hi @philip1986 I had a frist look at your test effort which I really like. what do I need to checkout to run the tests? Can I simply chckou the "feature/add_tests" branch? |
@mwittig ok than I will go on whit this tests. Yes just checkout the branch and run npm install. |
@philip1986 Added suggested fix for issue #19 |
See commit log for details