-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there's a crtiical bug in this code #46
Comments
Is there an actual bug or is conversion to ARC just a nice-to-have? Because manual retain-release still works, and doesn't require the new runtime which is why I haven't done it yet (I have an app that uses it that is old, supports old OSes). I know how to convert to ARC. But in this case, PhFacebook is a separate framework so you can link it to an ARC-enabled app with no issues that I know of. Unless there's an actual bug I see no reason to keep this request open with this title. |
I found the parent wasn't getting callback when targeting 10.10 JP On Friday, June 19, 2015, Philippe Casgrain notifications@github.com
John Pope | Senior Software Engineer Port Melbourne, Australia |
I removed the naked ivar access which, for some reason, I only had done in one class. Try it now? |
Having not heard back, closing the issue. |
I suggest you migrate it to use arc
in xcode > edit > convert to objectice-c ARC
the synthesized variables can all be deleted.
You shouldn't need any private variables here > as they were the same name - and I was seeing no respnse from the parent. I'd commit my code on fork but don't have time for thorough testing.
@interface PhWebViewController : NSObject
{
// delete these as the conflict PhFacebook *parent;
}
@Property (unsafe_unretained) IBOutlet NSWindow *window;
@Property (unsafe_unretained) IBOutlet WebView *webView;
@Property (unsafe_unretained) IBOutlet NSButton *cancelButton;
@Property (nonatomic,unsafe_unretained) PhFacebook *parent;
@Property (nonatomic, strong) NSString *permissions;
The text was updated successfully, but these errors were encountered: