apply linting rules

.eslintignore

@@ -1,3 +1,4 @@
 dist/*
 node_modules/*
-**/node_modules/*
+**/node_modules/*
+app/scripts/vexflow-min.js

.eslintrc

@@ -29,7 +29,7 @@
     "react/react-in-jsx-scope": 2,
     "react/self-closing-comp": 2,
     "react/wrap-multilines": 2,
-    "quotes": [2, "single"],
+    "quotes": [2, "double"],
     "space-before-function-paren": [2, {
       "anonymous": "always",
       "named": "never"
@@ -39,4 +39,4 @@
   "plugins": [
     "react"
   ]
-}
+}

app/scripts/App.js

@@ -1,8 +1,8 @@
 require("../styles/index.less");
 
-import React, {Component} from 'react';
-import MainView from './views/main_view';
-import StatisticService from './services/statistic_service.js';
+import React, {Component} from "react";
+import MainView from "./views/main_view";
+import StatisticService from "./services/statistic_service.js";
 
 
 export default class App extends Component {

app/scripts/index.js

@@ -1,8 +1,8 @@
-import React from 'react';
-import {render} from 'react-dom';
-import App from './App';
+import React from "react";
+import {render} from "react-dom";
+import App from "./App";
 
 render(
   <App />,
-  document.getElementById('root')
+  document.getElementById("root")
 );

app/scripts/services/key_converter.js

@@ -1,4 +1,4 @@
-import _ from 'lodash';
+import _ from "lodash";
 
 export default class KeyConverter {
 
@@ -11,7 +11,7 @@ export default class KeyConverter {
 
   getNumberForCanonicalKeyString(keyString) {
 
-    return parseInt(_.findKey(this.keyMap, function(key) { return key === keyString; }), 10);
+    return parseInt(_.findKey(this.keyMap, function (key) { return key === keyString; }), 10);
   }
 
 
@@ -47,7 +47,7 @@ export default class KeyConverter {
 
   getCanonicalForm(key) {
 
-    const stripKey = function(keyToStrip, modifier) {
+    const stripKey = function (keyToStrip, modifier) {
 
       const regexp = new RegExp(modifier, "g");
       // ignore the first character because of b notes
@@ -88,7 +88,7 @@ export default class KeyConverter {
       "c", "c#", "d", "d#", "e", "f", "f#", "g", "g#", "a", "a#", "b"
     ];
 
-    var claviature = baseScale.slice(-3).concat(_.flatten(_.times(7, function() { return baseScale; }))).concat([baseScale[0]]);
+    var claviature = baseScale.slice(-3).concat(_.flatten(_.times(7, function () { return baseScale; }))).concat([baseScale[0]]);
 
 
     var keyMap = {};

app/scripts/services/midi_service.js

@@ -1,4 +1,4 @@
-import KeyConverter from '../services/key_converter.js';
+import KeyConverter from "../services/key_converter.js";
 
 export default class MidiService {
 
@@ -38,7 +38,7 @@ export default class MidiService {
 
     const debugMode = true;
     if (debugMode) {
-      document.addEventListener('keyup', (event) => {
+      document.addEventListener("keyup", (event) => {
         const trueKeyCode = 84;
         const falseKeyCode = 70;
         if (event.keyCode === trueKeyCode) {

app/scripts/services/statistic_service.js

@@ -1,4 +1,4 @@
-import _ from 'lodash';
+import _ from "lodash";
 
 export default class StatisticService {
 
@@ -42,7 +42,7 @@ export default class StatisticService {
   }
 
   getSuccessCount() {
-    return _(this.stats).filter(function(el) { return el.success; }).value().length;
+    return _(this.stats).filter(function (el) { return el.success; }).value().length;
   }
 
 
@@ -97,7 +97,7 @@ export default class StatisticService {
 
 
   getLastDays(n = 10) {
-    return _(this.stats).filter(function(el) { return el.success; }).map(function(el) {
+    return _(this.stats).filter(function (el) { return el.success; }).map(function (el) {
       el.formattedDate = [
         el.date.getUTCFullYear(),
         ("0" + el.date.getMonth()).slice(-2),

app/scripts/spec/key_converter_spec.js

@@ -1,11 +1,11 @@
-import KeyConverter from '../services/key_converter.js';
-import _ from 'lodash';
+import KeyConverter from "../services/key_converter.js";
+import _ from "lodash";
 
-describe("KeyConverter", function() {
+describe("KeyConverter", function () {
 
   var keyConverter = new KeyConverter();
 
-  it("resolves a simple note", function() {
+  it("resolves a simple note", function () {
 
     var numberA0 = keyConverter.getNumberForKeyString("a/0");
     expect(numberA0).toBe(21);
@@ -16,7 +16,7 @@ describe("KeyConverter", function() {
 
   );
 
-  it("gets key strings for a number", function() {
+  it("gets key strings for a number", function () {
 
     var aSharp0 = keyConverter.getKeyStringForNumber("22");
     expect(aSharp0).toBe("a#/0");
@@ -27,7 +27,7 @@ describe("KeyConverter", function() {
 
   );
 
-  it("gets scales for an arbitrary base", function() {
+  it("gets scales for an arbitrary base", function () {
 
     var cScale = keyConverter.getScaleForBase("c/4");
     expect(cScale).toEqual(["c/4", "d/4", "e/4", "f/4", "g/4", "a/4", "b/4"]);
@@ -42,7 +42,7 @@ describe("KeyConverter", function() {
 
   );
 
-  return it("gets the canonical form of a key", function() {
+  return it("gets the canonical form of a key", function () {
 
     var c4 = keyConverter.getCanonicalForm("c/4");
     expect(c4).toBe("c/4");

app/scripts/spec/midi_service_spec.js

@@ -1,16 +1,16 @@
-import KeyConverter from '../services/key_converter.js';
-import _ from 'lodash';
+import KeyConverter from "../services/key_converter.js";
+import _ from "lodash";
 
-describe("MidiService", function() {
+describe("MidiService", function () {
 
   var onKeyStatus = MidiService.onKeyStatus;
   var offKeyStatus = MidiService.offKeyStatus;
 
-  it("notifies about a simple desired key state (midi implementation 1)", function() {
+  it("notifies about a simple desired key state (midi implementation 1)", function () {
 
     var [successCounter, failedCounter] = [0, 0];
-    var successCallback = function() { return successCounter++; };
-    var failureCallback = function() { return failedCounter++; };
+    var successCallback = function () { return successCounter++; };
+    var failureCallback = function () { return failedCounter++; };
 
     var midiService = new MidiService(successCallback, failureCallback, null, null, true);
     midiService.setDesiredKeys(["a/0"]);
@@ -31,11 +31,11 @@ describe("MidiService", function() {
 
   );
 
-  it("notifies about a simple desired key state (midi implementation 2)", function() {
+  it("notifies about a simple desired key state (midi implementation 2)", function () {
 
     var [successCounter, failedCounter] = [0, 0];
-    var successCallback = function() { return successCounter++; };
-    var failureCallback = function() { return failedCounter++; };
+    var successCallback = function () { return successCounter++; };
+    var failureCallback = function () { return failedCounter++; };
 
     var midiService = new MidiService(successCallback, failureCallback, null, null, true);
     midiService.setDesiredKeys(["a/0"]);
@@ -56,11 +56,11 @@ describe("MidiService", function() {
 
   );
 
-  it("notifies about a complex desired key state", function() {
+  it("notifies about a complex desired key state", function () {
 
     var [successCounter, failedCounter] = [0, 0];
-    var successCallback = function() { return successCounter++; };
-    var failureCallback = function() { return failedCounter++; };
+    var successCallback = function () { return successCounter++; };
+    var failureCallback = function () { return failedCounter++; };
 
     var midiService = new MidiService(successCallback, failureCallback, null, null, true);
     midiService.setDesiredKeys(["a/0", "c/8"]);
@@ -82,11 +82,11 @@ describe("MidiService", function() {
   }
   );
 
-  return it("notifies once about a wrong desired key state", function() {
+  return it("notifies once about a wrong desired key state", function () {
 
     var [successCounter, failedCounter] = [0, 0];
-    var successCallback = function() { return successCounter++; };
-    var failureCallback = function() { return failedCounter++; };
+    var successCallback = function () { return successCounter++; };
+    var failureCallback = function () { return failedCounter++; };
 
     var midiService = new MidiService(successCallback, failureCallback, null, null, true);
     midiService.setDesiredKeys(["a/0", "c/8"]);

app/scripts/test_config.js

@@ -3,7 +3,7 @@ for (var file in window.__karma__.files) {
     if (/spec\.js$/.test(file)) {
       // remove absolute path elements so that all dependencies
       // will be fetched with file extension
-      file = file.replace(/^\/base\/|\.js$/g,'');
+      file = file.replace(/^\/base\/|\.js$/g,"");
       tests.push(file);
     }
 }
@@ -13,9 +13,9 @@ requirejs.config({
     // baseUrl: '/base',
 
     // ask Require.js to load the application Require.js configuration
-    deps: ['base/scripts/require_config'],
+    deps: ["base/scripts/require_config"],
 
-    callback: function() {
+    callback: function () {
       // overwrite the baseUrl (was set by require_config.js)
       require.config({baseUrl : "/base"});
 

app/scripts/views/main_view.js

@@ -1,11 +1,11 @@
-import Vex from 'vexflow';
-import React, {Component} from 'react';
-import StatisticsView from '../views/statistics_view.js';
-import MidiService from '../services/midi_service.js';
-import KeyConverter from '../services/key_converter.js';
-import classNames from 'classnames';
+import Vex from "vexflow";
+import React, {Component} from "react";
+import StatisticsView from "../views/statistics_view.js";
+import MidiService from "../services/midi_service.js";
+import KeyConverter from "../services/key_converter.js";
+import classNames from "classnames";
 
-const successMp3Url = require('file!../../resources/success.mp3');
+const successMp3Url = require("file!../../resources/success.mp3");
 
 export default class MainView extends Component {
 
@@ -136,7 +136,7 @@ export default class MainView extends Component {
 
 
   playSuccessSound() {
-    return document.getElementById('success-player').play();
+    return document.getElementById("success-player").play();
   }
 
 
@@ -233,7 +233,7 @@ export default class MainView extends Component {
     var generatedChords = _.range(0, options.notesPerBar).map( () => {
       var randomLevel = _.sample(options.levels[clef]);
 
-      var generateNote = function(baseNotes) {
+      var generateNote = function (baseNotes) {
         var randomNoteIndex = _.random(0, baseNotes.length - 1);
         var note = baseNotes.splice(randomNoteIndex, 1)[0];
 

app/scripts/views/statistics_view.js

@@ -1,7 +1,7 @@
-import Chartist from 'Chartist';
-import React, {Component} from 'react';
-import StatisticService from '../services/statistic_service.js';
-import KeyConverter from '../services/key_converter.js';
+import Chartist from "Chartist";
+import React, {Component} from "react";
+import StatisticService from "../services/statistic_service.js";
+import KeyConverter from "../services/key_converter.js";
 
 export default class StatisticsView extends Component {
 
@@ -17,7 +17,7 @@ export default class StatisticsView extends Component {
         <h4>The last days you trained:</h4>
         <ul>
         {
-            statistics.getLastDays(10).map(function(el){
+            statistics.getLastDays(10).map(function (el){
             <li>
               { (el.averageTime / 1000).toFixed(2) }s average
               ({ (el.totalTime / 1000 / 60).toFixed(2) } min)

package.json

@@ -32,7 +32,7 @@
     "babel-preset-react": "^6.3.13",
     "babel-preset-stage-0": "^6.3.13",
     "css-loader": "^0.23.1",
-    "eslint": "^0.21.2",
+    "eslint": "^2.2.0",
     "eslint-plugin-react": "^2.3.0",
     "karma": "^0.12.23",
     "karma-beep-reporter": "^0.1.4",