-
Notifications
You must be signed in to change notification settings - Fork 95
Conversation
composer.json updates
…wed w3c trace context specification, removed ramsey/uuid dependency
@YuZhenXie , thank you very much for your contribution! Please note that the agent is released now with support of the Furthermore, please note that the Agent is already able to register a parent, have a look at the |
# Conflicts: # README.md # src/Events/EventBean.php # src/Events/Transaction.php
Please have a look at the travis ci failures |
Thanks for your feedback! I will test it in 2 Lumen projects again tomorrow and let you know if any issue :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuZhenXie , thanks a lot for your contribution. I left some review comments. Please make sure you add yourself to the contributors list on the README.md
and the developers in composer.json
*/ | ||
protected $transaction; | ||
|
||
private $parentId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parentId
should no longer be necessary because of the parent
attribute of EventBean
…arentId for aligning with w3c specification
I am currently working on distributed tracing function.
Following is the main modification:
TracingGuzzleMiddleware
which is used to inject tracepareant header for Guzzle client.timestamp
in EventBean can be used as parameter in v2 intake APIThis is tested in 2 Lumen projects and works fine. I am not sure which target branch I should set so I set v2-support.