Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Support distributed tracing #86

Merged
merged 23 commits into from
Aug 27, 2019
Merged

Conversation

YuZhenXie
Copy link
Contributor

I am currently working on distributed tracing function.
Following is the main modification:

  1. Make trace context follow w3c specification
  2. Resolve trace context when creating a new transaction
  3. Make TracingGuzzleMiddleware which is used to inject tracepareant header for Guzzle client.
  4. timestamp in EventBean can be used as parameter in v2 intake API

This is tested in 2 Lumen projects and works fine. I am not sure which target branch I should set so I set v2-support.

@YuZhenXie YuZhenXie closed this Aug 22, 2019
@YuZhenXie YuZhenXie reopened this Aug 22, 2019
@philkra philkra self-requested a review August 23, 2019 06:57
@philkra
Copy link
Owner

philkra commented Aug 23, 2019

@YuZhenXie , thank you very much for your contribution! Please note that the agent is released now with support of the v2 Intake API (PR #83 ). Could you please resolve the conflicts and merge against master? Thanks a lot in advance.

Furthermore, please note that the Agent is already able to register a parent, have a look at the EventBean::setParent(Transaction) method.

@philkra
Copy link
Owner

philkra commented Aug 26, 2019

Please have a look at the travis ci failures

@YuZhenXie
Copy link
Contributor Author

Thanks for your feedback! I will test it in 2 Lumen projects again tomorrow and let you know if any issue :)

Copy link
Owner

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuZhenXie , thanks a lot for your contribution. I left some review comments. Please make sure you add yourself to the contributors list on the README.md and the developers in composer.json

composer.json Show resolved Hide resolved
*/
protected $transaction;

private $parentId;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parentId should no longer be necessary because of the parent attribute of EventBean

src/Events/EventBean.php Show resolved Hide resolved
src/Events/EventBean.php Outdated Show resolved Hide resolved
src/Events/EventBean.php Show resolved Hide resolved
src/Events/EventBean.php Outdated Show resolved Hide resolved
src/TraceParent.php Outdated Show resolved Hide resolved
src/TraceParent.php Outdated Show resolved Hide resolved
src/TraceParent.php Show resolved Hide resolved
@philkra philkra changed the base branch from v2-support to master August 27, 2019 08:41
@philkra philkra merged commit 83c42e3 into philkra:master Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants