Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`lentic-doc-external-view' launch eww #18

Closed
tumashu opened this issue Feb 16, 2015 · 5 comments
Closed

`lentic-doc-external-view' launch eww #18

tumashu opened this issue Feb 16, 2015 · 5 comments

Comments

@tumashu
Copy link

tumashu commented Feb 16, 2015

(defun lentic-doc-external-view ()
  (interactive)
  (lentic-doc-ensure-doc)
  (browse-url-of-file lentic-doc-file))

I use GNU Emacs 24.4.1 (i686-pc-mingw32)GNU Emacs 24.4.1 (i686-pc-mingw32)
`lentic-doc-external-view' lanuch eww instead of ie ,

I think we should use:

(defun lentic-doc-external-view ()
  (interactive)
  (lentic-doc-ensure-doc)
  (browse-url-default-browser lentic-doc-file))
@phillord
Copy link
Owner

Can you explain a bit more please. What are you seeing that you don't like, and how would this change improve the situation?

@tumashu
Copy link
Author

tumashu commented Feb 17, 2015

The reason is that we have lentic-doc-eww-view', Iflentic-doc-external-view' launch eww, it seem meanless.

@phillord
Copy link
Owner

tumashu notifications@github.com writes:

The reason is that we have lentic-doc-eww-view', Iflentic-doc-external-view' launch eww, it seem meanless.


Reply to this email directly or view it on GitHub:
#18 (comment)

Yes. Are you saying this is what happens? For me,
lentic-doc-external-view pops up an external browser.

Phil

@tumashu
Copy link
Author

tumashu commented Feb 17, 2015

lentic-doc-external launch eww in my machine

@phillord
Copy link
Owner

Okay, will fix. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants