Return selector after consuming combinator #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the change to parse all tokens, a selector is returned when encountering a
:comma
token.When we
consume_combinators
, that callsdo_parse
which gets a selector and continues on parsing tokens. However, the selector is returned as a result of matching:comma
token and removes it from the remaining tokens. So when parsing continues afterconsume_combinator
, it continues parsing the previous selector instead of starting a new one.This changes so
consume_combinator
functions return a selector tuple since they will get a fully completed selector after parsing.I think this covers all the missing cases, but would definitely love close 👀 and any suggestions you believe may still need to be tested.