Skip to content

Commit

Permalink
Replace '…' with '...'
Browse files Browse the repository at this point in the history
Use the longer form version of '…' to prevent possible rendering issues.
  • Loading branch information
philwebb committed May 20, 2020
1 parent 7028251 commit 5fbe330
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ default Method getRequiredSetter() {
* final String id;
* final String name;
*
* //
* // ...
*
* Person withName(String name) {
* return new Person(this.id, name);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ static class KotlinCopyUtil {
private static final Map<Class<?>, KCallable<?>> copyMethodCache = new ConcurrentReferenceHashMap<>();

/**
* Set a single property by calling {@code copy()} on a Kotlin data class.
* Set a single property by calling {@code copy(...)} on a Kotlin data class.
* Copying creates a new instance that holds all values of the original instance
* and the newly set {@link PersistentProperty} value.
*
Expand All @@ -147,8 +147,9 @@ static <T> Object setProperty(PersistentProperty<?> property, T bean, @Nullable
Class<?> type = property.getOwner().getType();
KCallable<?> copy = copyMethodCache.computeIfAbsent(type, it -> getCopyMethod(it, property));
if (copy == null) {
throw new UnsupportedOperationException(String.format(
"Kotlin class %s has no .copy(…) method for property %s!", type.getName(), property.getName()));
throw new UnsupportedOperationException(
String.format("Kotlin class %s has no .copy(...) method for property %s!", type.getName(),
property.getName()));
}
return copy.callBy(getCallArgs(copy, property, bean, value));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ private Class<PersistentPropertyAccessor<?>> createAccessorClass(PersistentEntit
* case 3359:
* this.bean = PersonWithId.copy$default(bean, value, 0, null); // Kotlin
* return;
* //
* // ...
* }
* throw new UnsupportedOperationException(
* String.format("No accessor to set property %s!", new Object[] { property }));
Expand All @@ -295,10 +295,10 @@ private Class<PersistentPropertyAccessor<?>> createAccessorClass(PersistentEntit
* return id_fieldGetter.invoke(bean);
* case 3356:
* return bean.getField();
* //
* // ...
* case 3357:
* return bean.field;
* //
* // ...
* throw new UnsupportedOperationException(
* String.format("No accessor to get property %s!", new Object[] { property }));
* }
Expand Down Expand Up @@ -403,7 +403,7 @@ private static List<PersistentProperty<?>> getPersistentProperties(PersistentEnt
* private final Object bean;
* private static final MethodHandle $id_fieldGetter;
* private static final MethodHandle $id_fieldSetter;
* //
* // ...
* </pre>
*/
private static void visitFields(PersistentEntity<?, ?> entity, List<PersistentProperty<?>> persistentProperties,
Expand Down Expand Up @@ -490,7 +490,7 @@ private static void visitDefaultConstructor(PersistentEntity<?, ?> entity, Strin
* field.setAccessible(true);
* $id_fieldGetter = lookup.unreflectGetter(field);
* $id_fieldSetter = lookup.unreflectSetter(field);
* //
* // ...
* }
* </pre>
*/
Expand Down Expand Up @@ -716,10 +716,10 @@ private static void visitBeanGetter(PersistentEntity<?, ?> entity, String intern
* return id_fieldGetter.invoke(bean);
* case 3356:
* return bean.getField();
* //
* // ...
* case 3357:
* return bean.field;
* //
* // ...
* }
* throw new UnsupportedOperationException(
* String.format("No MethodHandle to get property %s", new Object[] { property }));
Expand Down Expand Up @@ -806,7 +806,7 @@ private static void visitGetProperty0(PersistentEntity<?, ?> entity, PersistentP
false);
}
else {
// bean.get
// bean.get...
mv.visitVarInsn(ALOAD, 2);
int invokeOpCode = INVOKEVIRTUAL;
Class<?> declaringClass = getter.getDeclaringClass();
Expand Down Expand Up @@ -862,7 +862,7 @@ private static void visitGetProperty0(PersistentEntity<?, ?> entity, PersistentP
* case 3359:
* this.bean = PersonWithId.copy$default(bean, value, 0, null); // Kotlin
* return;
* //
* // ...
* }
* throw new UnsupportedOperationException(
* String.format("No accessor to set property %s!", new Object[] { property }));
Expand Down Expand Up @@ -1008,8 +1008,8 @@ private static void visitWithProperty(PersistentEntity<?, ?> entity, PersistentP
private static void visitKotlinCopy(PersistentEntity<?, ?> entity, PersistentProperty<?> property,
MethodVisitor mv, String internalClassName) {
KotlinCopyMethod kotlinCopyMethod = KotlinCopyMethod.findCopyMethod(entity.getType())
.orElseThrow(() -> new IllegalStateException(
String.format("No usable .copy() method found in entity %s", entity.getType().getName())));
.orElseThrow(() -> new IllegalStateException(String
.format("No usable .copy(...) method found in entity %s", entity.getType().getName())));
// this. <- for later PUTFIELD
mv.visitVarInsn(ALOAD, 0);
if (kotlinCopyMethod.shouldUsePublicCopyMethod(entity)) {
Expand All @@ -1025,7 +1025,7 @@ private static void visitKotlinCopy(PersistentEntity<?, ?> entity, PersistentPro
mv.visitVarInsn(ALOAD, 3);
KotlinCopyByProperty copyByProperty = kotlinCopyMethod.forProperty(property)
.orElseThrow(() -> new IllegalStateException(
String.format("No usable .copy() method found for property %s", property)));
String.format("No usable .copy(...) method found for property %s", property)));
for (int i = 1; i < kotlinCopyMethod.getParameterCount(); i++) {
if (copyByProperty.getParameterPosition() == i) {
mv.visitVarInsn(ALOAD, 2);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@

/**
* {@link RepositoryInvoker} that is aware of a {@link QuerydslPredicateExecutor} and
* {@link Predicate} to be executed for all flavors of {@code findAll()}. All other calls
* are forwarded to the configured delegate.
* {@link Predicate} to be executed for all flavors of {@code findAll(...)}. All other
* calls are forwarded to the configured delegate.
*
* @author Oliver Gierke
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class DeferredRepositoryInitializationListener implements ApplicationListener<Co

@Override
public void onApplicationEvent(ContextRefreshedEvent event) {
logger.info("Triggering deferred initialization of Spring Data repositories");
logger.info("Triggering deferred initialization of Spring Data repositories...");
this.beanFactory.getBeansOfType(Repository.class);
logger.info("Spring Data repositories initialized!");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ protected boolean isLazy(DependencyDescriptor descriptor) {
}
boolean lazyInit = configuration.isLazyInit();
if (lazyInit) {
logger.debug(LogMessage.format("Creating lazy injection proxy for %s",
logger.debug(LogMessage.format("Creating lazy injection proxy for %s...",
configuration.getRepositoryInterface()));
}
return lazyInit;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
*/
public class PropertiesBasedNamedQueries implements NamedQueries {

private static final String NO_QUERY_FOUND = "No query with name %s found! Make sure you call hasQuery() before calling this method!";
private static final String NO_QUERY_FOUND = "No query with name %s found! Make sure you call hasQuery(...) before calling this method!";

public static final NamedQueries EMPTY = new PropertiesBasedNamedQueries(new Properties());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ boolean isSort() {
* the type parameter of the actually returned type.
* <p>
* <code>
* <T> Collection<T> findBy…(…, Class<T> type);
* <T> Collection<T> findBy...(..., Class<T> type);
* </code>
* @param parameter must not be {@literal null}.
* @return
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@
* public class ExampleClass {
*
* String shouldNotReturnNull(@Nullable String acceptsNull, String doesNotAcceptNull) {
* //
* // ...
* }
*
* &#64;Nullable
* String nullableReturn(String parameter) {
* //
* // ...
* }
* }
* </pre>
Expand Down

0 comments on commit 5fbe330

Please sign in to comment.