Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom task/type support #1225

Merged
merged 3 commits into from
Jan 1, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Dec 26, 2019

I made a little composer plugin https://github.com/siad007/phing-configurator to allow custom tasks/types support. An example task would be configured like https://github.com/MehrAlsNix/custom-phing-task-example/blob/develop/composer.json

@mrook What do you think? And could you create a new repo (+ packagist) for this composer plugin?

Related to #654

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #1225 into master will increase coverage by 0.2%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1225     +/-   ##
===========================================
+ Coverage     47.49%   47.69%   +0.2%     
+ Complexity     9967     9920     -47     
===========================================
  Files           507      506      -1     
  Lines         24505    24432     -73     
===========================================
+ Hits          11638    11654     +16     
+ Misses        12867    12778     -89
Impacted Files Coverage Δ Complexity Δ
classes/phing/ComponentHelper.php 79.75% <71.42%> (-1.73%) 55 <8> (+8)
classes/phing/util/SourceFileScanner.php 61.76% <0%> (-7.36%) 21% <0%> (ø)
classes/phing/util/StringHelper.php 88.37% <0%> (+2.32%) 25% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054c72c...049a2ee. Read the comment docs.

@mrook
Copy link
Member

mrook commented Dec 30, 2019

@siad007 great stuff! I've created https://github.com/phingofficial/phing-composer-configurator. Let me know when you've committed the code there, I'll create a packagist package for it.

@siad007
Copy link
Member Author

siad007 commented Dec 30, 2019

@siad007 great stuff! I've created https://github.com/phingofficial/phing-composer-configurator. Let me know when you've committed the code there, I'll create a packagist package for it.

@mrook Just added the plugin to the new repo 😃

@siad007 siad007 merged commit 7ae0d1a into phingofficial:master Jan 1, 2020
@siad007 siad007 deleted the CustomComponentsSupport branch January 1, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants