Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExecTask] Fixed resolving env vars #1254

Merged
merged 7 commits into from
Feb 9, 2020
Merged

[ExecTask] Fixed resolving env vars #1254

merged 7 commits into from
Feb 9, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 8, 2020

@jawira would you mind have a look if this would work for you?

Related to #1253

@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #1254 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1254      +/-   ##
===========================================
+ Coverage     50.09%   50.1%   +0.01%     
- Complexity     9500    9503       +3     
===========================================
  Files           486     486              
  Lines         23292   23300       +8     
===========================================
+ Hits          11667   11675       +8     
  Misses        11625   11625
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/ExecTask.php 86.52% <100%> (+0.58%) 83 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918eb8f...d13246c. Read the comment docs.

@siad007 siad007 merged commit e3c3679 into master Feb 9, 2020
@siad007 siad007 deleted the siad007-patch-1 branch February 9, 2020 00:19
@siad007 siad007 linked an issue Mar 28, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Phing Exec env sub tag is not working
1 participant