Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HTTP_Request2 with GuzzleHttp #1288

Merged
merged 3 commits into from Mar 26, 2020
Merged

Replace HTTP_Request2 with GuzzleHttp #1288

merged 3 commits into from Mar 26, 2020

Conversation

mrook
Copy link
Member

@mrook mrook commented Mar 26, 2020

Fixes #1160.

What do you think @siad007 @kenguest ?

@mrook mrook changed the title Replace HTTP_Request2 Replace HTTP_Request2 with GuzzleHttp Mar 26, 2020
@mrook mrook requested review from siad007 and kenguest March 26, 2020 08:41
@mrook
Copy link
Member Author

mrook commented Mar 26, 2020

Docs still need to be updated.

Copy link
Member

@kenguest kenguest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - unfortunately I'm not currently in a position to test the code but it all seems fine.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #1288 into master will increase coverage by 0.01%.
The diff coverage is 85.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1288      +/-   ##
============================================
+ Coverage     51.03%   51.04%   +0.01%     
+ Complexity     9299     9296       -3     
============================================
  Files           479      479              
  Lines         22751    22732      -19     
============================================
- Hits          11610    11603       -7     
+ Misses        11141    11129      -12     
Impacted Files Coverage Δ Complexity Δ
...sses/phing/tasks/ext/visualizer/VisualizerTask.php 82.81% <0.00%> (ø) 41.00 <2.00> (ø)
classes/phing/tasks/ext/HttpGetTask.php 82.60% <83.33%> (-11.01%) 20.00 <11.00> (ø)
classes/phing/tasks/ext/HttpRequestTask.php 85.71% <91.66%> (+21.92%) 19.00 <9.00> (-3.00) ⬆️
classes/phing/tasks/ext/HttpTask.php 91.11% <95.00%> (+3.87%) 19.00 <9.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fedad4...4748330. Read the comment docs.

@kenguest kenguest merged commit 7afaf75 into master Mar 26, 2020
@mrook mrook deleted the replace-http-request branch January 29, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

get_magic_quotes_runtime() deprecated in 7.4 - replace HTTP_Request2
2 participants