Add tests and correct TouchTask behavior #1456
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
============================================
+ Coverage 52.68% 52.72% +0.03%
- Complexity 9205 9207 +2
============================================
Files 469 469
Lines 22351 22357 +6
============================================
+ Hits 11776 11787 +11
+ Misses 10575 10570 -5
Continue to review full report at Codecov.
|
| * drift to account for a lag between when we noted the time and when | ||
| * the file was touched. | ||
| */ | ||
| $this->assertThat(filemtime($testFile), new IsEqual($nowTime, 1), 'File timestamp not within 1 second of now'); |
There was a problem hiding this comment.
$this->assertEqualsWithDelta(filemtime($testFile), $nowTime, 1, 'File timestamp not within 1 second of now')
| <filelist dir="." files="${tmp.dir}/idonotexist" /> | ||
| <mapper type="merge" to="${tmp.dir}/touchtest" /> | ||
| </touch> | ||
| </target> | ||
|
|
||
| <target name="testMillis"> | ||
| <touch file="${tmp.dir}/millis-file" millis="946684799864" /> <!-- Friday, December 31, 1999 11:59:59.864 PM --> |
There was a problem hiding this comment.
Please test against milliseconds not microseconds.
There was a problem hiding this comment.
It is milliseconds:
| @@ -1,4 +1,6 @@ | |||
| <?php | |||
| use PHPUnit\Framework\Constraint\IsEqual; | |||
There was a problem hiding this comment.
Please move after file comment!
| $testFile = $this->getProject()->getProperty('tmp.dir') . '/millis-file'; | ||
| $this->assertFileExists($testFile); | ||
|
|
||
| $this->assertEquals('December 31 1999 23:59:59', date("F d Y H:i:s", filemtime($testFile))); |
There was a problem hiding this comment.
Do you mean something like this?
$this->assertEquals('December 31 1999 23:59:59.000000', date("F d Y H:i:s.u", filemtime($testFile)));There was a problem hiding this comment.
Seems unnecessary as filemtime() would always return the milliseconds as .000000.
Change testDefaultToNow() to use assertEqualsWithDelta instead of assertThat with an IsEquals constraint.
There was a problem hiding this comment.
@BlairCooper please check https://github.com/phingofficial/phing/pull/1456/checks?check_run_id=1513668571#step:5:633
[phpunit] Testsuite: TimerTest
[phpunit] Tests run: 1, Risky: 0, Warnings: 0, Failures: 1, Errors: 0, Incomplete: 0, Skipped: 0, Time elapsed: 0.01496 s
[phpunit] testTimer FAILED
[phpunit] Failed asserting that '0.00194' matches expected 0.0.
Hmm seems not related. So I will approve. THX for your PR.
Fixes #1452, #1453, #1454
actually contains. Retain millis attribute for continuity with the ANT
Touch task - [TouchTask] millis attribute leads to invalid dates #1453